Date: Sun, 19 Nov 2000 12:46:17 -0800 (PST) From: Matthew Jacob <mjacob@feral.com> To: Alfred Perlstein <bright@wintelcom.net> Cc: Doug Rabson <dfr@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha clock.c db_interface.c interrupt.c mp_machdep.c prom.c vm_machdep.c Message-ID: <Pine.LNX.4.21.0011191245380.20827-100000@zeppo.feral.com> In-Reply-To: <20001119124403.M18037@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 19 Nov 2000, Alfred Perlstein wrote: > * Doug Rabson <dfr@FreeBSD.org> [001119 04:29] wrote: > > dfr 2000/11/19 04:28:42 PST > > > > Modified files: > > sys/alpha/alpha clock.c db_interface.c interrupt.c > > mp_machdep.c prom.c vm_machdep.c > > Log: > > Convert various calls to splhigh() to disable_intr() since splhigh() is > > now a no-op. > > Afaik the concensus was that spl's were not to be removed even > though they are no-ops. > > You should probably put them back. No, actually they're needed and they are there. This is all specifically machine dependent code areas, and places where, for example, the prom is entered, interrupts really do need to be disabled. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.21.0011191245380.20827-100000>