Date: Thu, 2 Jun 2011 15:52:48 -0400 From: Wesley Shields <wxs@FreeBSD.org> To: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/erlyvideo Makefile pkg-plist Message-ID: <20110602195248.GA62894@atarininja.org> In-Reply-To: <4DE7D4B4.3040302@yandex.ru> References: <201106021631.p52GVgHM038132@repoman.freebsd.org> <20110602165708.GA61311@atarininja.org> <4DE7D4B4.3040302@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 02, 2011 at 10:21:40PM +0400, Ruslan Mahmatkhanov wrote:
> 02.06.2011 20:57, Wesley Shields ??????????:
>
> >> | @@ -39,6 +40,7 @@ post-patch:
> >> | ${WRKSRC}/priv/${PORTNAME}.conf.sample
> >> | @${FIND} ${WRKSRC} -type f -name .gitignore | ${XARGS} ${RM}
> >> | @${FIND} ${WRKSRC} -type f -name "*.bak" | ${XARGS} ${RM}
> >> | + @${FIND} ${WRKSRC} -type f -name "*.orig" | ${XARGS} ${RM}
> >> | @${RMDIR} ${WRKSRC}/src/plugins
> >
> > I understand Ruslan was just following the convention used in this port
> > but I don't like this construct. We should at least be doing -print0 |
> > xargs -0 if we are going to be using xargs like this. I, personally,
> > would prefer us to use the -delete option to find.
>
> I'm fully agree with that findelete stuff, so here is the patch,
> thanks for pointing out. Surely i picked this construct in some
> another port, but can't recall which one.
Thanks for taking care of this quickly. I will try and scour the tree in
the upcoming days to find more cases of this.
> >
> > I wonder if there are other places in the ports tree where a similar
> > construct can be found that we should also cleanup.
> >
> > -- WXS
>
> There is plenty of ports that use `find | xargs rm/rmdir` construct.
> ros-*/rox-* ports for example.
Thanks for pointing these out!
-- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110602195248.GA62894>