Date: Thu, 22 Dec 2011 21:05:05 -0500 From: Greg Larkin <glarkin@FreeBSD.org> Cc: Doug Barton <dougb@freebsd.org>, Christer Edwards <christer.edwards@gmail.com>, "freebsd-ports@FreeBSD.org" <freebsd-ports@freebsd.org> Subject: Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port) Message-ID: <4EF3E1D1.1020901@FreeBSD.org> In-Reply-To: <4EF3E0EF.8040405@FreeBSD.org> References: <CAH2d3%2BvMF8jM6GHJQ6DR7EywmnY%2Bj=0tSHFEf_5oW1C6QhYD8A@mail.gmail.com> <4EEC6D9D.1020102@yandex.ru> <CAH2d3%2Btr8deqeGLPywXAXsRDPt_-3GwpkqPhK=zk5PtztvkK6g@mail.gmail.com> <4EEEAE03.1080908@yandex.ru> <CAH2d3%2BtE8s%2Bf6ni9GLdh0nHTQdN50BeaoAQ6%2BnYTrUBbJAiKDA@mail.gmail.com> <4EF2FBAE.8050406@yandex.ru> <CAH2d3%2BvWDbahx_kuo9_T8ezK2W9JGxyy74czeUTDopKKUzrQfg@mail.gmail.com> <4EF393BC.2020003@yandex.ru> <CAH2d3%2Bs1Tkizqoa5-spY92A82fgXxJ1m53Or4Fb5SPGhZKG4iw@mail.gmail.com> <CAH2d3%2Btd83z%2Bb0UG%2BH8%2BFmCe-A=dk1FAYd6k=1J43GrybyHsng@mail.gmail.com> <4EF3CF11.6070104@FreeBSD.org> <CAH2d3%2BtJT==ZbJxopTJiPewvS%2B6JOeAf_RSVdzD9fBBeDkEpYg@mail.gmail.com> <4EF3E0EF.8040405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/22/11 9:01 PM, Greg Larkin wrote: > On 12/22/11 8:34 PM, Christer Edwards wrote: >> On Thu, Dec 22, 2011 at 5:45 PM, Doug Barton <dougb@freebsd.org> wrote: >>> There are some style problems and one real bug that are repeated for all >>> 3 scripts. I attached a fixed version of one of them, hopefully that >>> will help you see what's needed to fix the other 2. Also, please review >>> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html, >>> especially the pre-commit checklist. > >> I made the changes you suggested and tried a fresh build of the port >> inside of a jail. Below is a pastebin of trying to start the >> service(s) just after installation. > >> http://pastebin.com/raw.php?i=2wGBk0PY > >> thanks > > Hi Christer, > > The salt-master script is interpreted by Python, so I believe you'll > need the following in your rc.d script: > > command_interpreter="%%PYTHON_CMD%%" > > and the proper SUB_LIST setting in the Makefile. Check the py-fail2ban > port for some pointers on that. > > Hope that helps, > Greg Also, I forgot to mention that when I'm faced with similar rc.d problems, I invoke the script with "sh -x" like so: sh -x /usr/local/etc/rc.d/viewvc start That prints all of the shell variable debug information, echoes commands, etc. I would be interested in seeing that output if you can post it to pastebin. I'm not sure my previous suggestion will help anyway, and it looks like your $command variable is trashed somewhere while the script executes. Regards, Greg -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7z4dEACgkQ0sRouByUApDzfgCgkoTH5sNuPr+jEdbp9rplFD2b BoAAoJbTTQBZi0oL8URD7C71/7hsKVgU =Uu2Z -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EF3E1D1.1020901>