Date: Wed, 06 Mar 2002 10:13:34 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: "Mike Meyer" <mwm-dated-1015836666.0b65c5@mired.org> Cc: "Mike Meyer" <mwm-dated-1015832287.8470f8@mired.org>, "Mike Meyer" <mwm-dated-1015831171.a21ab0@mired.org>, obrien@FreeBSD.ORG, Giorgos Keramidas <keramida@FreeBSD.ORG>, hackers@FreeBSD.ORG Subject: Re: RFC: style(9) isn't explicit about booleans for testing. Message-ID: <14189.1015406014@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 06 Mar 2002 02:51:06 CST." <15493.55418.457017.332630@guru.mired.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <15493.55418.457017.332630@guru.mired.org>, "Mike Meyer" writes:
>Poul-Henning Kamp <phk@critter.freebsd.dk> types:
>> In message <15493.51038.957711.450030@guru.mired.org>, "Mike Meyer" writes:
>> I'm advocating that the rule focus on readability rather than trying
>> to enforce a type which doesn't exist.
>
>Excellent idea. Can you provide verbiage and examples?
All you have to do is get rid of the word boolean, ie: change
Do not use ! for tests unless it is a boolean, e.g. use
to
Do not use ! for tests unless it is an integer type, e.g. use
And as far as I'm concerned the confusion is gone.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14189.1015406014>