Date: Tue, 24 Apr 2018 13:38:53 -0400 From: Andrew Gallatin <gallatin@cs.duke.edu> To: "Jonathan T. Looney" <jtl@freebsd.org>, John Baldwin <jhb@freebsd.org> Cc: Mark Johnston <markj@freebsd.org>, cem@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332860 - head/sys/kern Message-ID: <744fa604-c33c-5f58-6443-4c485136b4fb@cs.duke.edu> In-Reply-To: <CADrOrmunCxzSpBZe35XwX7ZSFyPuSEpvEraKmQP2MdSP8ZMEGw@mail.gmail.com> References: <201804211705.w3LH50Dk056339@repo.freebsd.org> <CADrOrmvAxuoadBM==1EEbJc4PAPwtd-vPE4Tg-pM86CvwQnnwA@mail.gmail.com> <20180423180024.GC84833@raichu> <1739228.8pyHcvzasL@ralph.baldwin.cx> <CADrOrmunCxzSpBZe35XwX7ZSFyPuSEpvEraKmQP2MdSP8ZMEGw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/24/18 13:24, Jonathan T. Looney wrote: > On Mon, Apr 23, 2018 at 6:04 PM, John Baldwin <jhb@freebsd.org > <mailto:jhb@freebsd.org>> wrote: > > > > I think this is actually a key question. In my experience to date I > have not > > encountered a large number of post-panic assertion failures. Given that > > we already break all locks and disable assertions for locks I'd be > curious > > which assertions are actually failing. My inclination given my > experiences > > to date would be to explicitly ignore those as we do for locking if it is > > constrained set rather than blacklisting all of them. However, I > would be > > most interested in seeing some examples of assertions that are failing. > > The latest example (the one that prompted me to finally commit this) is > in lockmgr_sunlock_try(): 'panic: Assertion (*xp & > ~LK_EXCLUSIVE_SPINNERS) == LK_SHARERS_LOCK(1) failed at > /usr/src/sys/kern/kern_lock.c:541' > > I don't see any obvious recent changes that would have caused this, so > this is probably a case where a change to another file suddenly made us > trip over this assert. FWIW, that assertion has prevented me from getting a dump from an INVARIANTS kernel for at least a year. Drew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?744fa604-c33c-5f58-6443-4c485136b4fb>