Date: Tue, 14 Jun 2005 02:43:45 +0000 (UTC) From: Peter Wemm <peter@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/syscons scgfbrndr.c scvgarndr.c Message-ID: <200506140243.j5E2hjnh044694@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
peter 2005-06-14 02:43:45 UTC
FreeBSD src repository
Modified files:
sys/dev/syscons scgfbrndr.c scvgarndr.c
Log:
Fix syscons on amd64. The SC_PIXEL_MODE commit from May 29th added a new
function pointer to the vga render dispatch table and initialized it with
vga_nop. The problem is that vga_nop() is a varargs function, and the
table declares a non-varargs function pointer. On amd64 (and I think ppc),
mixing varargs and non-varargs function pointers is fatal.
Change vga_nop() and gfb_nop() from varargs to non-varargs do-nothing
functions. This stops the stack corruption that only happened on amd64.
Approved by: re (scottl)
Revision Changes Path
1.22 +2 -2 src/sys/dev/syscons/scgfbrndr.c
1.19 +2 -2 src/sys/dev/syscons/scvgarndr.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506140243.j5E2hjnh044694>