Date: Fri, 18 Jul 2014 07:41:38 +0000 (UTC) From: Peter Wemm <peter@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r268833 - head/sys/dev/bge Message-ID: <201407180741.s6I7fcJn003675@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: peter Date: Fri Jul 18 07:41:38 2014 New Revision: 268833 URL: http://svnweb.freebsd.org/changeset/base/268833 Log: Fix an apparent conversion error in bge to the new driver api. if_multiaddr_array() does the LLADDR work, don't do it twice. This broke IPv6 in "interesting" ways in the FreeBSD.org cluster. Modified: head/sys/dev/bge/if_bge.c Modified: head/sys/dev/bge/if_bge.c ============================================================================== --- head/sys/dev/bge/if_bge.c Fri Jul 18 07:18:37 2014 (r268832) +++ head/sys/dev/bge/if_bge.c Fri Jul 18 07:41:38 2014 (r268833) @@ -1646,8 +1646,8 @@ bge_setmulti(struct bge_softc *sc) if_multiaddr_array(ifp, mta, &mcnt, mc_count); for(i = 0; i < mcnt; i++) { - h = ether_crc32_le(LLADDR((struct sockaddr_dl *) - (mta + (i * ETHER_ADDR_LEN))), ETHER_ADDR_LEN) & 0x7F; + h = ether_crc32_le(mta + (i * ETHER_ADDR_LEN), + ETHER_ADDR_LEN) & 0x7F; hashes[(h & 0x60) >> 5] |= 1 << (h & 0x1F); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201407180741.s6I7fcJn003675>