Date: Mon, 16 Feb 1998 09:55:19 +1030 From: Greg Lehey <grog@lemis.com> To: "Jordan K. Hubbard" <jkh@time.cdrom.com> Cc: Chris Csanady <ccsanady@friley585.res.iastate.edu>, freebsd-current@FreeBSD.ORG Subject: Re: CCD missing spl() call.. Message-ID: <19980216095519.33042@freebie.lemis.com> In-Reply-To: <16771.887583090@time.cdrom.com>; from Jordan K. Hubbard on Sun, Feb 15, 1998 at 02:51:30PM -0800 References: <19980216075421.52560@freebie.lemis.com> <16771.887583090@time.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 15 February 1998 at 14:51:30 -0800, Jordan K. Hubbard wrote:
>> I don't know what function you were referring to, since you don't
>> mention the name. All I have to go on is the original patch:
>
> ccdintr().
>
>> This patch definitely applies to ccdiodone. Look at the text in the
>
> Odd, for me it applied to ccdintr() with lots of fuzz. :-)
Presumably because the modification was already in there. Certainly
it was wrong where it put it. Consider the patch:
***************
*** 973,978 ****
--- 973,979 ----
register int unit = cbp->cb_unit;
int count, s;
+ s = splbio();
#ifdef DEBUG
if (ccddebug & CCDB_FOLLOW)
printf("ccdiodone(%x)\n", cbp);
Hunk #2 succeeded at 938 with fuzz 2 (offset -35 lines).
What it did was:
--- ccd.c 1998/01/31 03:19:06 1.28
+++ ccd.c 1998/02/15 23:20:43
@@ -938,6 +938,7 @@
register struct buf *bp;
{
+ s = splbio();
#ifdef DEBUG
if (ccddebug & CCDB_FOLLOW)
printf("ccdintr(%x, %x)\n", cs, bp);
That's a little too fuzzy for my liking.
Greg
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980216095519.33042>