Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Jun 2016 21:52:23 +1000
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        Hans Petter Selasky <hps@selasky.org>, Slawa Olhovchenkov <slw@zxy.spb.ru>, Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        ports@FreeBSD.org, FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: pkg SAT_SOLVER bugs
Message-ID:  <44a43ec3-4f64-3de6-4f48-cb1b7231f9a2@FreeBSD.org>
In-Reply-To: <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org>
References:  <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 27/06/2016 8:38 PM, Hans Petter Selasky wrote:
> Hi,
> 
> I found some bugs in PKG with regard to the SAT_SOLVER environment
> variable. Please find patch attached :-)

Nice! Can you report upstream @ https://github.com/freebsd/pkg if you
haven't already

> Issues fixed:
> 1) No need to use hash table when generating SAT rules for external
> solver. Variables are already in a linear array. Fix encoding and
> decoding of SAT data.
> 2) Endless variable loop caused pkg to crash.
> 3) it->inverse was checked for non-zero, while it should actually be
> checked for -1 only. SAT rules produces were all negative.
> 
> How to verify:
> 
> make -C /usr/ports/math/picosat all install clean
> 
> env SAT_SOLVER=picosat pkg upgrade
> 
> --HPS




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44a43ec3-4f64-3de6-4f48-cb1b7231f9a2>