Date: Thu, 4 Sep 2025 01:30:43 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Alexander Ziaee <ziaee@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 458ac2b6e445 - main - umb.4: Improve synposis, add netmap Message-ID: <56905A32-EAE7-4447-B830-AAFF6DD20A5D@FreeBSD.org> In-Reply-To: <65F7C538-6AF3-429B-AC08-541A7C7CA1D0@FreeBSD.org> References: <E1up5xv-0005kE-9z@rmmprod07.runbox> <65F7C538-6AF3-429B-AC08-541A7C7CA1D0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Aug 21, 2025, at 11:02 PM, Zhenlei Huang <zlei@FreeBSD.org> wrote: > > > >> On Aug 21, 2025, at 10:08 PM, Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>> wrote: >> >> On 2025-08-20 23:21 -04:00 EDT, "Zhenlei Huang" <zlei@FreeBSD.org <mailto:zlei@FreeBSD.org>> wrote: >>> Hi Alexander, >>> >>> I'd presume umb(4) does not depends on netmap. A quick search of DEV_NETMAP >>> >>> ``` >>> #ifdef DEV_NETMAP >>> static void umb_input(if_t , struct mbuf *); >>> #endif >>> ... >>> #ifdef DEV_NETMAP >>> if_setinputfn(ifp, umb_input); >>> #endif >>> ``` >>> >>> I think the #ifdef can be removed. I currently do not have that hardware so I'd appreciate if someone can test it. >> >> I didn't get that far myself, this commit was partially in response to comment 67 [0] on the original bug where a user got the driver working on FreeBSD 14 by adding `device netmap` to their kernconf, and it didn't work without that. >> >> Should we send this to khorben? >> >> [0] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263783#c67 <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263783#c67>; > > I replied to PR 263783. Hi Alexander, I have just committed https://cgit.freebsd.org/src/commit/?id=e921d2842ee8ca9e3dae8952e1cf2645cee785aa <https://cgit.freebsd.org/src/commit/?id=e921d2842ee8ca9e3dae8952e1cf2645cee785aa>; . The man page now can be revised, I mean the netmap part should be removed. > +.Cd "device netmap" Best regards, Zhenlei > >> >> Best, >> Alex >> >>> >>> Best regards, >>> Zhenlei >>> >>>> On Aug 21, 2025, at 9:50 AM, Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>> wrote: >>>> >>>> The branch main has been updated by ziaee: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=458ac2b6e4452acc1a614352c8945ecc37667aa0 <https://cgit.freebsd.org/src/commit/?id=458ac2b6e4452acc1a614352c8945ecc37667aa0>; >>>> >>>> commit 458ac2b6e4452acc1a614352c8945ecc37667aa0 >>>> Author: Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>> >>>> AuthorDate: 2025-08-20 14:45:08 +0000 >>>> Commit: Alexander Ziaee <ziaee@FreeBSD.org <mailto:ziaee@FreeBSD.org>> >>>> CommitDate: 2025-08-21 01:48:13 +0000 >>>> >>>> umb.4: Improve synposis, add netmap >>>> >>>> Rewrite synopsis in a more consistent style, and add "device netmap", >>>> In FreeBSD 15, netmap is included in GENERIC/{amd64,arm64,powerpc64}, >>>> but it still needs to be used in FreeBSD 14 or custom kernels which >>>> don't include GENERIC. >>>> >>>> MFC after: umb does not mfc >>>> Reviewed by: gbe >>>> Differential Revision: https://reviews.freebsd.org/D51732 <https://reviews.freebsd.org/D51732>; >>>> --- >>>> share/man/man4/umb.4 | 28 ++++++++++++++-------------- >>>> 1 file changed, 14 insertions(+), 14 deletions(-) >>>> >>>> diff --git a/share/man/man4/umb.4 b/share/man/man4/umb.4 >>>> index 7ecc9a39c1ca..311a50faf8e7 100644 >>>> --- a/share/man/man4/umb.4 >>>> +++ b/share/man/man4/umb.4 >>>> @@ -17,34 +17,34 @@ >>>> .\" >>>> .\" $NetBSD: umb.4,v 1.4 2019/08/30 09:22:17 wiz Exp $ >>>> .\" >>>> -.Dd May 11, 2025 >>>> +.Dd August 4, 2025 >>>> .Dt UMB 4 >>>> .Os >>>> .Sh NAME >>>> .Nm umb >>>> .Nd USB Mobile Broadband Interface Model (MBIM) cellular modem driver >>>> .Sh SYNOPSIS >>>> -To compile this driver into the kernel, >>>> -place the following lines in your >>>> -kernel configuration file: >>>> -.Bd -ragged -offset indent >>>> +.Cd "device netmap" >>>> .Cd "device usb" >>>> .Cd "device umb" >>>> -.Ed >>>> .Pp >>>> -Alternatively, to load the driver as a >>>> -module at boot time, place the following line in >>>> +In >>>> .Xr loader.conf 5 : >>>> -.Bd -literal -offset indent >>>> -umb_load="YES" >>>> -.Ed >>>> -.Pp >>>> -If neither of the above is done, the driver will automatically be loaded >>>> -by devd(8) when the device is connected. >>>> +.Cd umb_load="YES" >>>> .Sh DESCRIPTION >>>> The >>>> .Nm >>>> driver provides support for USB MBIM devices. >>>> +If the appropriate hardware is detected, >>>> +the driver will be loaded automatically by >>>> +.Xr devmatch 8 . >>>> +To load the driver manually, >>>> +.Cm load >>>> +it in >>>> +.Xr loader.conf 5 >>>> +or at the >>>> +.Xr loader 8 >>>> +prompt. >>>> .Pp >>>> MBIM devices establish connections via cellular networks such as >>>> GPRS, UMTS, and LTE. [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Aug 21, 2025, at 11:02 PM, Zhenlei Huang <<a href="mailto:zlei@FreeBSD.org" class="">zlei@FreeBSD.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><br class="Apple-interchange-newline"><br class="" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;"><div class="">On Aug 21, 2025, at 10:08 PM, Alexander Ziaee <<a href="mailto:ziaee@FreeBSD.org" class="">ziaee@FreeBSD.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">On 2025-08-20 23:21 -04:00 EDT, "Zhenlei Huang" <</span><a href="mailto:zlei@FreeBSD.org" class="" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">zlei@FreeBSD.org</a><span class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">> wrote:</span><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" class="" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">Hi Alexander,<br class=""><br class="">I'd presume umb(4) does not depends on netmap. A quick search of DEV_NETMAP<br class=""><br class="">```<br class="">#ifdef DEV_NETMAP<br class="">static void umb_input(if_t , struct mbuf *);<br class="">#endif<br class="">...<br class="">#ifdef DEV_NETMAP<br class=""> if_setinputfn(ifp, umb_input);<br class="">#endif<br class="">```<br class=""><br class="">I think the #ifdef can be removed. I currently do not have that hardware so I'd appreciate if someone can test it.<br class=""></blockquote><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">I didn't get that far myself, this commit was partially in response to comment 67 [0] on the original bug where a user got the driver working on FreeBSD 14 by adding `device netmap` to their kernconf, and it didn't work without that.</span><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">Should we send this to khorben?</span><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">[0]<span class="Apple-converted-space"> </span></span><a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263783#c67" class="" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263783#c67</a><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"></div></blockquote><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">I replied to PR 263783. </div></div></blockquote><div><br class=""></div><div>Hi Alexander,</div><div><br class=""></div><div>I have just committed <a href="https://cgit.freebsd.org/src/commit/?id=e921d2842ee8ca9e3dae8952e1cf2645cee785aa" class="">https://cgit.freebsd.org/src/commit/?id=e921d2842ee8ca9e3dae8952e1cf2645cee785aa</a> .</div><div>The man page now can be revised, I mean the netmap part should be removed.</div><div><br class=""></div><div>> +.Cd "device netmap"</div><div><br class=""></div><div><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">Best regards,</div><div style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">Zhenlei</div></div><br class=""><blockquote type="cite" class=""><div class=""><br class="" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;"><div class=""><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">Best,</span><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><span class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">Alex</span><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br class="" style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" class="" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><br class="">Best regards,<br class="">Zhenlei<br class=""><br class=""><blockquote type="cite" class="">On Aug 21, 2025, at 9:50 AM, Alexander Ziaee <<a href="mailto:ziaee@FreeBSD.org" class="">ziaee@FreeBSD.org</a>> wrote:<br class=""><br class="">The branch main has been updated by ziaee:<br class=""><br class="">URL:<span class="Apple-converted-space"> </span><a href="https://cgit.freebsd.org/src/commit/?id=458ac2b6e4452acc1a614352c8945ecc37667aa0" class="">https://cgit.FreeBSD.org/src/commit/?id=458ac2b6e4452acc1a614352c8945ecc37667aa0</a><br class=""><br class="">commit 458ac2b6e4452acc1a614352c8945ecc37667aa0<br class="">Author: Alexander Ziaee <<a href="mailto:ziaee@FreeBSD.org" class="">ziaee@FreeBSD.org</a>><br class="">AuthorDate: 2025-08-20 14:45:08 +0000<br class="">Commit: Alexander Ziaee <<a href="mailto:ziaee@FreeBSD.org" class="">ziaee@FreeBSD.org</a>><br class="">CommitDate: 2025-08-21 01:48:13 +0000<br class=""><br class=""> umb.4: Improve synposis, add netmap<br class=""><br class=""> Rewrite synopsis in a more consistent style, and add "device netmap",<br class=""> In FreeBSD 15, netmap is included in GENERIC/{amd64,arm64,powerpc64},<br class=""> but it still needs to be used in FreeBSD 14 or custom kernels which<br class=""> don't include GENERIC.<br class=""><br class=""> MFC after: umb does not mfc<br class=""> Reviewed by: gbe<br class=""> Differential Revision: <a href="https://reviews.freebsd.org/D51732" class="">https://reviews.freebsd.org/D51732</a><br class="">---<br class="">share/man/man4/umb.4 | 28 ++++++++++++++--------------<br class="">1 file changed, 14 insertions(+), 14 deletions(-)<br class=""><br class="">diff --git a/share/man/man4/umb.4 b/share/man/man4/umb.4<br class="">index 7ecc9a39c1ca..311a50faf8e7 100644<br class="">--- a/share/man/man4/umb.4<br class="">+++ b/share/man/man4/umb.4<br class="">@@ -17,34 +17,34 @@<br class="">.\"<br class="">.\" $NetBSD: umb.4,v 1.4 2019/08/30 09:22:17 wiz Exp $<br class="">.\"<br class="">-.Dd May 11, 2025<br class="">+.Dd August 4, 2025<br class="">.Dt UMB 4<br class="">.Os<br class="">.Sh NAME<br class="">.Nm umb<br class="">.Nd USB Mobile Broadband Interface Model (MBIM) cellular modem driver<br class="">.Sh SYNOPSIS<br class="">-To compile this driver into the kernel,<br class="">-place the following lines in your<br class="">-kernel configuration file:<br class="">-.Bd -ragged -offset indent<br class="">+.Cd "device netmap"<br class="">.Cd "device usb"<br class="">.Cd "device umb"<br class="">-.Ed<br class="">.Pp<br class="">-Alternatively, to load the driver as a<br class="">-module at boot time, place the following line in<br class="">+In<br class="">.Xr loader.conf 5 :<br class="">-.Bd -literal -offset indent<br class="">-umb_load="YES"<br class="">-.Ed<br class="">-.Pp<br class="">-If neither of the above is done, the driver will automatically be loaded<br class="">-by devd(8) when the device is connected.<br class="">+.Cd umb_load="YES"<br class="">.Sh DESCRIPTION<br class="">The<br class="">.Nm<br class="">driver provides support for USB MBIM devices.<br class="">+If the appropriate hardware is detected,<br class="">+the driver will be loaded automatically by<br class="">+.Xr devmatch 8 .<br class="">+To load the driver manually,<br class="">+.Cm load<br class="">+it in<br class="">+.Xr loader.conf 5<br class="">+or at the<br class="">+.Xr loader 8<br class="">+prompt.<br class="">.Pp<br class="">MBIM devices establish connections via cellular networks such as<br class="">GPRS, UMTS, and LTE.</blockquote></blockquote></div></blockquote></div></blockquote></div><br class=""><div class=""> <div><br class=""></div> </div> <br class=""></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56905A32-EAE7-4447-B830-AAFF6DD20A5D>