Date: Wed, 28 May 2014 18:22:47 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org> Subject: Re: Investigating failed suspend/resume T61 Message-ID: <538661B7.1020203@FreeBSD.org> In-Reply-To: <53865FCA.6080407@FreeBSD.org> References: <1400861698.1126.0.camel@bruno> <201405281556.37651.jhb@freebsd.org> <538641DE.5030309@FreeBSD.org> <201405281729.35703.jhb@freebsd.org> <53865FCA.6080407@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2014-05-28 18:14:34 -0400, Jung-uk Kim wrote:
> On 2014-05-28 17:29:35 -0400, John Baldwin wrote:
>> Err, I think it enables GPE1 as otherwise ACPICA assumes GPE1 has
>> a length of zero (and is thus invalid)? Perhaps _PTS wants to
>> frob something that uses GPE1 that this fixes?
>
> static void AcpiTbValidateFadt ( void) { ... UINT8
> Length; ... for (i = 0; i < ACPI_FADT_INFO_ENTRIES; i++) { ...
> Length = *ACPI_ADD_PTR (UINT8, &AcpiGbl_FADT,
> FadtInfoTable[i].Length); ...
>
> Note the Length is read from the internal FADT and it is NOT a
> pointer.
>
> ... if (Address64->Address && (ACPI_MUL_8 (Length) <=
> ACPI_UINT8_MAX) && (Address64->BitWidth != ACPI_MUL_8 (Length))) {
> ACPI_BIOS_WARNING ((AE_INFO, "32/64X length mismatch in FADT/%s:
> %u/%u", Name, ACPI_MUL_8 (Length), Address64->BitWidth)); + if
> (Length == 0) + { + Length = ACPI_DIV_8
> (Address64->BitWidth); + } } ... } }
>
> AFAICT, it does change anything in AcpiGbl_FADT. ...
^
not
Sorry for the typo.
Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iQEcBAEBAgAGBQJThmG3AAoJEHyflib82/FGlGEIAIZBOaLiQSpFT8ziuK8vPP7s
WwI69o7tYzso16pbBjtaCV7eSD2uku+inSqNigmnp+FwvZGr4wxTOQSYMLSht9kw
CkiEjZ2wN4xA5rTCfvZzHlUgnVk4M9DAXjILiZ5W6+aURo5xRwkFNjVVQXPh2JXn
/JwmP7yJrRyVcm3KGKTR1c3rqoBzps3RP9RSz7I2bPZwzRfBTTTgiuuAjDy3LdUf
ozz6zGkknTGg/tPSATZULPWrzhfVWjfzwsTO3MbzQwynXtjVa0nmAO0Ug0iBiB0g
9ls1TdH/JSwaMMG3/8QlIkMp95jD5aTtpT2x1I78iWbptEX5N4pJ7uQctsFn09o=
=j9xm
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538661B7.1020203>