Date: Wed, 20 Jan 1999 22:59:26 +0800 From: Peter Wemm <peter@netplex.com.au> To: Eivind Eklund <eivind@FreeBSD.ORG> Cc: Robert Nordier <rnordier@nordier.com>, fenner@parc.xerox.com, bde@zeta.org.au, cvs-committers@FreeBSD.ORG Subject: Re: -Werror Message-ID: <199901201459.WAA20451@spinner.netplex.com.au> In-Reply-To: Your message of "Wed, 20 Jan 1999 15:45:10 %2B0100." <19990120154510.A64384@bitbox.follo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Eivind Eklund wrote:
> On Wed, Jan 20, 1999 at 04:31:29PM +0200, Robert Nordier wrote:
> > but rewriting to eliminate the errors would violate a style(9)
> > guideline (unnecessary parentheses). There's an awful lot of BSD
> > code like this, that could cause huge {Net,Open}BSD diffs if
> > rewritten.
>
> NetBSD and OpenBSD does, AFAIK, compile their kernel with -Wall
> -Werror.
I'm pretty sure I saw that NetBSD also do something like this for large
chunks of userland too. If I recall correctly (I don't have the source
handy), they have bsd.*.mk hook to enable tree based (Makefile.inc)
setting of the flags, and allowing overrides on a per directory basis as
well.
Re: style(9).. Some argue that parentheses to aid readability are
not "unnecessary". style(9) says "Don't add braces that aren't
necessary." - it doesn't say ".. for correct compilation". Having code
clear and readable is "necessary". :-)
> Eivind.
Cheers,
-Peter
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901201459.WAA20451>