Date: Sat, 10 Aug 2013 14:24:59 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Dan Mack <mack@macktronics.com> Cc: Lev Serebryakov <lev@FreeBSD.org>, freebsd-embedded@freebsd.org, freebsd-current@freebsd.org Subject: Re: nanobsd-built system doesn't have SVN revision in "uname" (and it looks like regression) Message-ID: <20130810182459.GF2432@glenbarber.us> In-Reply-To: <20130810181152.GE2432@glenbarber.us> References: <383656436.20130810150849@serebryakov.spb.ru> <37152758.20130810151846@serebryakov.spb.ru> <602958881.20130810180203@serebryakov.spb.ru> <CAJ-Vmo=nwiC-598%2BaaA4FFQCscjyox4PwTiDDMXb6SGFGGx3Ng@mail.gmail.com> <20130810141324.GD2432@glenbarber.us> <529930061.20130810191339@serebryakov.spb.ru> <alpine.BSF.2.00.1308101235030.26745@olive.macktronics.com> <alpine.BSF.2.00.1308101300350.2513@olive.macktronics.com> <20130810181152.GE2432@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
--GV0iVqYguTV4Q9ER
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Aug 10, 2013 at 02:11:52PM -0400, Glen Barber wrote:
> On Sat, Aug 10, 2013 at 01:09:20PM -0500, Dan Mack wrote:
> > It looks like you are doing the first [! -z '"${svnversion}"' ]
> > before $svnversion is being set. In the old version, this was
> > being set via:
> >=20
> > if [ -x /usr/bin/svnliteversion ] ; then
> > svnversion=3D/usr/bin/svnliteversion
> > fi
> >=20
> > But I'm not sure if that's intentional or not ...
> >=20
>=20
> Ugh. No, this was not intentional. I'll have this fixed shortly.
>=20
Fixed in r254184. The problem is that I was evaluating ${svnversion}
being set before looking for /usr/bin/svnliteversion; however when
_running_ /usr/bin/svnliteversion, it was being run as
/usr/bin/svnversion by mistake.
Thank you for the reports, and Dan, thank you for your help.
Glen
--GV0iVqYguTV4Q9ER
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)
iQEcBAEBCAAGBQJSBoV7AAoJEFJPDDeguUajcdkIAK7KFqFppIpLq2+Ws1qcsPDI
ddvJ8BaSGRFQKK3UHfxnJbbyIImKn4nsoQU9sFq+pgo91leIapWYuobLUAJCYs//
A72A5yoEL5tuMiyIK/h0Sd0DHWYnRPn/HXEh/rXXOihuMp38+AF0Vb0+RyoPz6/N
anvcQZosvNtziE7uybQUZoAyPw66+VW7SDNVxivYEEhcUbIKAFUShud4yU88HKpS
FfNBBsPUA/k9UVBjJdlVC4LOuucmwnx9ToKhS5SoWQLxo6nud1lzPidPeIBt2t5R
PmVGFs7ih6xa6+3P2PV+DcQvvBGgkDKbaW3QcqBNe6zrLilgfHS3Fk0pIsEF5gg=
=m02a
-----END PGP SIGNATURE-----
--GV0iVqYguTV4Q9ER--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130810182459.GF2432>