Date: Thu, 9 Mar 2006 10:38:03 +0200 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Garance A Drosehn <gad@FreeBSD.ORG>, Dag-Erling Smorgrav <des@FreeBSD.ORG> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/lpr/filters Makefile src/usr.sbin/lpr/filters.ru/koi2855 Makefile src/usr.sbin/lpr/filters.ru/koi2alt Makefile Message-ID: <20060309083803.GJ54826@ip.net.ua> In-Reply-To: <200603082228.k28MSDXJ050630@repoman.freebsd.org> References: <200603082228.k28MSDXJ050630@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Mar 08, 2006 at 10:28:13PM +0000, Garance A Drosehn wrote:
> gad 2006-03-08 22:28:13 UTC
>
> FreeBSD src repository
>
> Modified files:
> usr.sbin/lpr/filters Makefile
> usr.sbin/lpr/filters.ru/koi2855 Makefile
> usr.sbin/lpr/filters.ru/koi2alt Makefile
> Log:
> Switch these makefiles to use 'MAN=' to indicate they will not generate
> a man page, instead of 'NO_MAN='. 'NO_MAN=' is something users would
> set, not something a makefile should be using.
>
> Based on comments by: des
>
> Revision Changes Path
> 1.6 +1 -1 src/usr.sbin/lpr/filters.ru/koi2855/Makefile
> 1.6 +1 -1 src/usr.sbin/lpr/filters.ru/koi2alt/Makefile
> 1.6 +1 -1 src/usr.sbin/lpr/filters/Makefile
>
Please revert this change. Users can set NO_MAN, indeed, to indicate
they don't want manpages. But bsd.prog.mk makefiles that don't provide
a ${PROG}.1 manpage should set it (NO_MAN) themselves. This way it's
also faster to process: bsd.prog.mk doesn't include bsd.man.mk.
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFED+lrqRfpzJluFF4RAst/AKCGJ/r5cOMivKhOa0qoFJIdc5CB0ACfVoJc
ZqGO9Pgx0AsbSs+DAr+mFjA=
=qXA5
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060309083803.GJ54826>