Date: Tue, 31 Jul 2012 20:07:11 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Sean Bruno <seanbru@yahoo-inc.com> Cc: "svn-src-head@FreeBSD.org" <svn-src-head@FreeBSD.org>, "svn-src-all@FreeBSD.org" <svn-src-all@FreeBSD.org>, "src-committers@FreeBSD.org" <src-committers@FreeBSD.org> Subject: Re: svn commit: r238943 - head/sys/dev/acpica Message-ID: <501810BF.9010008@FreeBSD.org> In-Reply-To: <1343751146.2957.3.camel@powernoodle.corp.yahoo.com> References: <201207311058.q6VAwp18019777@svn.freebsd.org> <1343751146.2957.3.camel@powernoodle.corp.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31.07.2012 19:12, Sean Bruno wrote: > On Tue, 2012-07-31 at 03:58 -0700, Alexander Motin wrote: >> To help with diagnostics, add C-state type into >> dev.cpu.X.cx_supported. > > Pretty sure that this breaks /etc/rc.d/power_profile No, it doesn't. I've checked it beforehand. At least in my case variable was correctly set to C3. > Andiry and I went back and forth on this specific thing quite a bit. If > you note my commit/revert at svn r238004 and r238009 where I did a > similar thing and then had to yank it out. > > there's a lot of discussion around this point on the acpi mailing lists. > http://lists.freebsd.org/pipermail/freebsd-acpi/2012-July/007645.html I knew about that change and its revert. But it was much more invasive, substituting C-state index with C-state type, that I also consider incorrect. My change is much more simple. Yes, it may affect some POLA, but that is all. I wanted to do this for several years, and I believe that in this case benefits overweight negative side. But if someone tell I should back it out, I will. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?501810BF.9010008>