Date: Mon, 20 Mar 2017 10:45:45 -0500 From: Kyle Evans <bsdports@kyle-evans.net> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r435456 - in head: comms/wy60 deskutils/gbirthday devel/arduino-builder devel/cityhash devel/google-gdata devel/monodevelop emulators/citra games/openomf security/ssh-vault Message-ID: <CACNAnaFc7=eLP266xNhDiKN_V_B3%2BnXN3BSmHPaxMA2EzUD%2BHQ@mail.gmail.com> In-Reply-To: <201703050813.v258DSQt052933@repo.freebsd.org> References: <201703050813.v258DSQt052933@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 5, 2017 at 2:13 AM, Mathieu Arnold <mat@freebsd.org> wrote: > Author: mat > Date: Sun Mar 5 08:13:28 2017 > New Revision: 435456 > URL: https://svnweb.freebsd.org/changeset/ports/435456 > > Log: > Cleanup USE_GITHUB with GH_TUPLE usage. > > Do not use GH_TUPLE for the default distfile. > > With hat: portmgr > Sponsored by: Absolight > > Modified: > head/comms/wy60/Makefile (contents, props changed) > head/deskutils/gbirthday/Makefile (contents, props changed) > head/devel/arduino-builder/Makefile (contents, props changed) > head/devel/cityhash/Makefile (contents, props changed) > head/devel/google-gdata/Makefile (contents, props changed) > head/devel/monodevelop/Makefile (contents, props changed) > head/devel/monodevelop/distinfo (contents, props changed) > head/emulators/citra/Makefile (contents, props changed) > head/games/openomf/Makefile (contents, props changed) > head/security/ssh-vault/Makefile (contents, props changed) > > [...] > Modified: head/devel/arduino-builder/Makefile > ============================================================================== > --- head/devel/arduino-builder/Makefile Sun Mar 5 08:09:35 2017 (r435455) > +++ head/devel/arduino-builder/Makefile Sun Mar 5 08:13:28 2017 (r435456) > @@ -15,7 +15,7 @@ BUILD_DEPENDS= go:lang/go > > USE_GITHUB= yes > GH_ACCOUNT= arduino > -GH_SUBDIR= src/github.com/${GH_ACCOUNT}/${PORTNAME} > +GH_SUBDIR= src/github.com/${GH_ACCOUNT_DEFAULT}/${PORTNAME} > GH_TUPLE= go-errors:errors:a418503:goerrors/src/github.com/go-errors/errors \ > stretchr:testify:v1.1.3:stretchr/src/github.com/stretchr/testify \ > jstemmer:go-junit-report:833f8ea:jstemmer/src/github.com/jstemmer/go-junit-report Hi, With respect to the above change, may I ask where GH_ACCOUNT vs. GH_ACCOUNT_DEFAULT is most appropriately used? I'm not finding any documentation for the latter, but is it safe to assume that if I think I need to use GH_ACCOUNT elsewhere in the Makefile I should likely be using GH_ACCOUNT_DEFAULT instead?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFc7=eLP266xNhDiKN_V_B3%2BnXN3BSmHPaxMA2EzUD%2BHQ>