Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Jan 1998 12:12:11 +0100
From:      J Wunsch <j@uriah.heep.sax.de>
To:        freebsd-scsi@FreeBSD.ORG
Cc:        Carl.Makin@aipo.gov.au
Subject:   Re: seagate.c kernel compile error and sea device problems.
Message-ID:  <19980111121211.42324@uriah.heep.sax.de>
In-Reply-To: <4A256589.001DDBEF.00@notes.aipo.gov.au>; from Carl.Makin@aipo.gov.au on Sun, Jan 11, 1998 at 03:23:13PM %2B1000
References:  <4A256589.001DDBEF.00@notes.aipo.gov.au>

next in thread | previous in thread | raw e-mail | index | archive | help
As Carl.Makin@aipo.gov.au wrote:

> Under FreeBSD 2.2.5-RELEASE,
> 
> I get the following error from seagate.c when I compile a kernel.

They are not errors, but warnings.  You wouldn't have got a kernel at
all otherwise. ;)

> ../../i386/isa/seagate.c ../../i386/isa/seagate.c:581: warning: no previous
> prototype for `seaintr' ../../i386/isa/seagate.c: In function

(Your mailer clobbers long lines.)

That's sloppyness, but unless the functions are being used differently
than defined, it's totally benign.

> `sea_data_output': ../../i386/isa/seagate.c:1111: warning: assignment
> discards `volatile' from pointer target type ../../i386/isa/seagate.c: In
> function `sea_data_input': ../../i386/isa/seagate.c:1181: warning:
> assignment discards `volatile' from pointer target type sh

The argument p_data should probably be spelled with `volatile'
consistently throughout the driver.  gcc is not likely to optimize
accesses away on an x86 CPU outside of functions, however. ;-)

> I uncommented the "BLINDTRANSFERS" option and tried again with the
> autodetect sea0 config line and the errors started again.

There's probably nobody around anymore understanding the code better
than you do these days. :)

-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980111121211.42324>