Date: Sat, 21 Sep 2013 13:43:55 +0000 From: Brendan Fabeny <bf1783@gmail.com> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, ports-committers <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Pietro Cerutti <gahr@gahr.ch> Subject: Re: svn commit: r327601 - head/Mk Message-ID: <CAGFTUwMVd9j69VR9rrpZnnQNgMYVg3ptaYmXdv9XJY3b4i_enQ@mail.gmail.com> In-Reply-To: <CAMHz58SKkwR74fGy6=3ACXyczFoobOcDPfgb_tG14-v97RCFrA@mail.gmail.com> References: <201309190805.r8J855cW009011@svn.freebsd.org> <CAMHz58SSKvuXj%2B=3mXkZWuUL6VyOVee0s7%2BAeUOF5BhWNoVxUg@mail.gmail.com> <3D05DDAC-CF76-4109-9182-6DDAD924CCC5@gahr.ch> <20130920160700.GN73535@ithaqua.etoilebsd.net> <CAMHz58SKkwR74fGy6=3ACXyczFoobOcDPfgb_tG14-v97RCFrA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/21/13, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > On Sat, Sep 21, 2013 at 12:07 AM, Baptiste Daroussin > <bapt@freebsd.org>wrote: > >> On Fri, Sep 20, 2013 at 05:27:18PM +0200, Pietro Cerutti wrote: >> > >> > On 20-set-2013, at 10:32, Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> >> wrote: >> > >> > > Hi Bapt, >> > > >> > > May I suggest to change hard-coded sleep time to a settable variable >> defaults to 10? It would save time while checking multiple ports with >> terminal outputs redirected to a log file. >> > >> > Definitely +1 >> > >> I would be all for it, send me a patch and I will approve :) >> >> regards, >> Bapt >> > > A simple patch is here [1]. Thanks. > > [1] http://people.FreeBSD.org/~sunpoet/bsd.port.mk-sleep.patch It seems to me that having more than one configurable wait variable is overkill: there should be one and it should also cover the sleep in identify-install-conflicts; and it should default to 0 when BATCH or PACKAGE_BUILDING is set. I also do not think we should bother to include bsd.sanity.mk when DEVELOPER isn't set -- it is needless added work. b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGFTUwMVd9j69VR9rrpZnnQNgMYVg3ptaYmXdv9XJY3b4i_enQ>