Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jun 2010 15:49:09 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Jack F Vogel <jfv@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r209068 - head/sys/dev/e1000
Message-ID:  <201006151549.09210.jhb@freebsd.org>
In-Reply-To: <201006112054.o5BKsRk8087302@svn.freebsd.org>
References:  <201006112054.o5BKsRk8087302@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 11 June 2010 4:54:27 pm Jack F Vogel wrote:
> Author: jfv
> Date: Fri Jun 11 20:54:27 2010
> New Revision: 209068
> URL: http://svn.freebsd.org/changeset/base/209068
> 
> Log:
>   Add a couple fixes from Michael Tuexen.
>   Remove unneeded rxtx handler, make que handler generic.
>   Do not allocate header mbufs in rx ring if not doing hdr split.
>   Release the lock in rxeof call to stack.
>   
>   MFC for 8.1 asap

This causes a panic with MSIX is disabled (boot with hw.pci.msix_enabled=0).  
The reason is that in the !MSIX case, the rxtx_task is queued to the
adapter->tq queue, but in the MSIX case the task is queued to the per-queue
que->tq queue.  igb_handle_que() assumes the MSIX case, it is not generic.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006151549.09210.jhb>