Date: Sat, 13 Aug 2022 17:57:15 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 4e2a0135a0fd - main - mrsas module: Use MACHINE_ARCH exlcusively Message-ID: <202208131757.27DHvF7D088123@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=4e2a0135a0fd3dc59d8e7f48ccc1abf0e548bae7 commit 4e2a0135a0fd3dc59d8e7f48ccc1abf0e548bae7 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2022-08-13 17:53:22 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2022-08-13 17:56:53 +0000 mrsas module: Use MACHINE_ARCH exlcusively TARGET_ARCH is always wrong when not used at the toplevel Makefile*, or in something that has to be included from there. Switch to using MACHINE_ARCH exclusively here since there's no benefit from assigning TARGET_ARCH the value of MACHINE_ARCH and then using TARGET_ARCH (and make TARGET_ARCH=xxx won't work). Sponsored by: Netflix --- sys/modules/mrsas/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/modules/mrsas/Makefile b/sys/modules/mrsas/Makefile index c3c7580805fe..130a46a8ad5f 100644 --- a/sys/modules/mrsas/Makefile +++ b/sys/modules/mrsas/Makefile @@ -15,8 +15,7 @@ SRCS+= device_if.h bus_if.h pci_if.h opt_cam.h opt_scsi.h .include <bsd.kmod.mk> CFLAGS+= -fgnu89-inline -TARGET_ARCH = ${MACHINE_ARCH} -.if ${TARGET_ARCH} == "amd64" +.if ${MACHINE_ARCH} == "amd64" CFLAGS+= -DCOMPAT_FREEBSD32 .endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202208131757.27DHvF7D088123>