Date: Tue, 15 Oct 2013 16:28:21 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Bryan Drewery <bryan@shatow.net> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com>, Allan Jude <freebsd@allanjude.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Devin Teske <dteske@FreeBSD.org> Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Message-ID: <13CA24D6AB415D428143D44749F57D720FC6A61F@LTCFISWMSGMB21.FNFIS.com> In-Reply-To: <525D5E07.1070900@allanjude.com> References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <20131015145032.GD98118@admin.xzibition.com> <13CA24D6AB415D428143D44749F57D720FC6A04C@LTCFISWMSGMB21.FNFIS.com> <525D5E07.1070900@allanjude.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 15, 2013, at 8:23 AM, Allan Jude wrote: > On 2013-10-15 11:00, Teske, Devin wrote: >> CC'ing Allan Jude for feedback (I didn't have a hand in the >> selection of those values) >>=20 >> --=20 >> Devin >>=20 >>=20 >> On Oct 15, 2013, at 7:50 AM, Bryan Drewery wrote: >>=20 >>=20 >>> >=20 >>> On Fri, Oct 11, 2013 at 08:41:35PM +0000, Devin Teske wrote: >>>=20 >>>> >>=20 >>>> Author: dteske >>>>=20 >>>> >>=20 >>>> Date: Fri Oct 11 20:41:35 2013 >>>>=20 >>>> >>=20 >>>> New Revision: 256343 >>>>=20 >>>> >> URL: http://svnweb.freebsd.org/changeset/base/256343 >>>> >>=20 >>>> >>=20 >>>> Log: >>>>=20 >>>> >>=20 >>>> Add zfsboot module as an option for automatic configuration. Default = is >>>>=20 >>>> >>=20 >>>> to run interactively but it can be scripted too (optinally completely >>>>=20 >>>> >>=20 >>>> non-interactive). Currently supports GELI and all ZFS vdev types. Also >>>>=20 >>>> >>=20 >>>> performs validation on selections/settings providing error messages if >>>>=20 >>>> >>=20 >>>> necessary, explaining (in plain language) what the issue is. Currently >>>>=20 >>>> >>=20 >>>> the auto partitioning of naked disks only supports GPT and MBR (VTOC8 >>>>=20 >>>> >>=20 >>>> pending for sparc64), so is only available for i386/amd64 install. >>>>=20 >>>> >>=20 >>>> >> Submitted by: Allan Jude <freebsd@allanjude.com> >>>> , myself >>>>=20 >>>> >> Reviewed by: Allan Jude <freebsd@allanjude.com> >>>> >>=20 >>>> Approved by: re (glebius) >>>>=20 >>>> >>=20 >>>> >>=20 >>>> Added: >>>>=20 >>>> >>=20 >>>> head/usr.sbin/bsdinstall/scripts/zfsboot (contents, props changed) >>>>=20 >>>> >>=20 >>>> Modified: >>>>=20 >>>> >>=20 >>>> head/usr.sbin/bsdinstall/bsdinstall >>>>=20 >>>> >>=20 >>>> head/usr.sbin/bsdinstall/scripts/Makefile >>>>=20 >>>> >>=20 >>>> head/usr.sbin/bsdinstall/scripts/auto >>>>=20 >>>> >>=20 >>>> head/usr.sbin/bsdinstall/scripts/config >>>>=20 >>>> >>=20 >>>> >>=20 >>>> +# Should we use gnop(8) to configure a transparent mapping to 4K sect= ors? >>>>=20 >>>> >>=20 >>>> +# >>>>=20 >>>> >>=20 >>>> +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=3D1} >>>>=20 >>> >=20 >>> >=20 >>> I believe this trick is no longer needed after r254591. >>>=20 >=20 > This may be the case, I am not sure if r254591 'always' fixes the problem= , maybe someone else can weight in with a more definite yes/no >=20 I'll hold off on doing anything with 4K sectors gnop hack until we get confirmation. >=20 >>> >=20 >>>> >>=20 >>>> *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** >>>>=20 >>> >=20 >>> ... >>>=20 >>>> >>=20 >>>> +# Default name for the boot environment parent dataset >>>>=20 >>>> >>=20 >>>> +# >>>>=20 >>>> >>=20 >>>> +: ${ZFSBOOT_BEROOT_NAME:=3Dbootenv} >>>>=20 >>> >=20 >>> ... >>>=20 >>>> >>=20 >>>> + # Set bootfs property >>>>=20 >>>> >>=20 >>>> + zpool set bootfs=3D"$poolname/$ZFSBOOT_BEROOT_NAME/$ZFSBOOT_BO= OTFS_NAME" \ >>>>=20 >>>> >>=20 >>>> + "$poolname" || return $FAILURE >>>>=20 >>> >=20 >>> >=20 >>> Can you please make ZFSBOOT_BEROOT_NAME be ROOT by default? This is what >>>=20 >>> >=20 >>> sysutils/beadm, OpenSolaris/Illumos beadm, and I believe PC-BSD all exp= ect >>>=20 >>> > and use as well. >=20 > I suppose. I dislike having a dataset in all caps, and with a not exactly= descriptive name. beadm-devel (used in PCBSD) supports figuring out where = whatever ZFSBOOT_BEROOT_NAME you used, but since sysutils/beadm does not, P= OLA suggests we change the value back to ROOT >=20 So we have consensus? I need to know today if we're going to get it into 10.0-BETA2 (3-day MFC cy= cle). --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13CA24D6AB415D428143D44749F57D720FC6A61F>