Date: Wed, 6 Mar 2002 16:46:01 +1100 From: "Tim J. Robbins" <tim@robbins.dropbear.id.au> To: Kyle Martin <mkm@ieee.org> Cc: freebsd-standards@FreeBSD.ORG Subject: Re: ls(1) patch for review Message-ID: <20020306164601.A31721@descent.robbins.dropbear.id.au> In-Reply-To: <20020305224856.A1397@marvin.idsi.net>; from mkm@ieee.org on Tue, Mar 05, 2002 at 10:48:56PM -0600 References: <20020305030632.A1990@marvin.idsi.net> <20020305205733.A31150@descent.robbins.dropbear.id.au> <20020305224856.A1397@marvin.idsi.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 05, 2002 at 10:48:56PM -0600, Kyle Martin wrote:
> + case 'x':
> + f_sortacross = 1;
> + break;
I think you should also have:
f_column = f_longform = f_singlecol = 0;
There might be other issues with options taking precedence over others.
Compare the output of these two:
ls -Cq | more
ls -xq | more
(ie. output is not tty)
Also in printstream(), you should probably try to avoid printing empty
lines by not always doing the final putchar('\n').
Apart from the \t\n thing I mentioned in the previous email, I can't see
anything else wrong with it..
Tim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-standards" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020306164601.A31721>