Date: Tue, 03 Oct 2000 12:19:07 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: freebsd-smp@FreeBSD.org, Jake Burkholder <jburkhol@home.com> Subject: Re: witness code status? Message-ID: <XFMail.001003121907.jhb@FreeBSD.org> In-Reply-To: <200010031908.e93J8OS00830@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03-Oct-00 Steve Kargl wrote: > John Baldwin wrote: >> >> On 03-Oct-00 Jake Burkholder wrote: >> > Attached is a patch that should fix this. >> > Please let me know and I'll commit it. (Works here.) >> >> Ugh. How and why does this work exactly, and should we be >> #include'ing opt_user_ldt.h in an include file instead, or >> should we move USER_LDT to opt_global.h perhaps? >> > > Well, it appears to work because > troutmask:sgk[247] find /sys/ -name \*.h | xargs grep USER_LDT > /sys/compile/TROUTMASK/opt_user_ldt.h:#define USER_LDT 1 > /sys/i386/include/globaldata.h:#ifdef USER_LDT > /sys/i386/include/globals.h:#ifdef USER_LDT > /sys/i386/include/globals.h:#ifdef USER_LDT Argh. Ok. In some other header files we create dummy variables so that the structs remain the same. > And kern_idle.c includes > >#include <machine/globaldata.h> >#include <machine/globals.h> > > which suggests that yes USER_LDT should move to opt_global.h. I'll work up a patch to do this in a sec. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001003121907.jhb>