Date: Mon, 11 Mar 2024 02:17:33 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Vladimir Druzenko <vvd@freebsd.org>, Nuno Teixeira <eduardo@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 021fcd36af22 - main - games/coffeebreak: Move man pages to share/man Message-ID: <Ze5pvZ23YQiyRjyH@FreeBSD.org> In-Reply-To: <4knrc5ywvwupkrkzgevfpbclp3hhq5eojt6l4iigwn2w64krre@cfbbk7q6efg3> References: <202403090831.4298VJo6024021@gitrepo.freebsd.org> <Ze16dMKKJxs9IN3t@FreeBSD.org> <CAFDf7UKq-onz-dbR=pm03Ji1FHb-u81Cidohi-be-EnVvYsGUQ@mail.gmail.com> <CAFDf7UJnP66UooFnRLxnhJS_B0j3hDfc%2Bc7uwh%2BGkNXNB_xukA@mail.gmail.com> <CAFDf7UKQ9ibp=46YuZRVpK-HDkeU92HKMkjWst1-t7oSMOBggw@mail.gmail.com> <Ze3YBw8CwWTEDxYg@FreeBSD.org> <32f6aa31-5d2e-401f-9c2c-eec41c14e60f@freebsd.org> <4knrc5ywvwupkrkzgevfpbclp3hhq5eojt6l4iigwn2w64krre@cfbbk7q6efg3>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 10, 2024 at 09:31:19PM +0100, Mathieu Arnold wrote:
> On Sun, Mar 10, 2024 at 08:33:55PM +0300, Vladimir Druzenko wrote:
> > 10.03.2024 18:55, Alexey Dokuchaev пишет:
> > > On Sun, Mar 10, 2024 at 10:47:07AM +0000, Nuno Teixeira wrote:
> > > > (...)
> > > >
> > > > Works fine:
> > > >
> > > > +MAKE_ARGS= PREFIX=${PREFIX} MANDIR=${STAGEDIR}${PREFIX}/share/man
> > > >
> > > > What do you think? This way it is nicely simplified without patch
> > > > or sed.
> > >
> > > Yes, this is what I had in mind.
> >
> > I tested same for other ports - doesn't work if Makefile have line:
> > MANDIR= XXX but work if it have: MANDIR?= XXX
You don't have to *test* this as it were some kind of magic, this is
well known and documented make(1) behaviour. Could you be confusing
with MAKE_ENV perhaps?
> Variables passed as arguments will override variables set with = or ?=
> Variables in the environemnt will override variables set with ?=
Right. Alas, apparently this is still needs to be explained even to
some seasoned ports committers. :-/
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Ze5pvZ23YQiyRjyH>