Date: Wed, 10 Nov 2004 10:13:40 +0200 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Christian Brueffer <chris@unixpages.org> Cc: net@FreeBSD.ORG Subject: Re: sf(4) device polling Message-ID: <20041110081340.GD65475@ip.net.ua> In-Reply-To: <20041109164942.GC555@unixpages.org> References: <20041109164942.GC555@unixpages.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--i7F3eY7HS/tUJxUd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Christian,
On Tue, Nov 09, 2004 at 05:49:42PM +0100, Christian Brueffer wrote:
> the attached patch implements device polling for the sf(4) driver. It
> has been running on my home gateway for almost two weeks now, without any
> ill effects.
>=20
> I'd appreciate it, when someone could review/commit this.
>=20
Unfortunately, I cannot give this patch a real testing as I don't have
the hardware in question, but I did the code inspection and found only
three bugs. ;)
1. The done_locked: label should be put in #ifdef DEVICE_POLLING,
or it will cause compile-time warning if compiling without
the DEVICE_POLLING option.
2. The condition to call if_start() in sf_poll_locked() was
broken twice: there's an extra semicolon at the end of the
"if" line, and while this conditional is valid for ALTQ,
it's not for this driver, as it doesn't yet support it
(perhaps your local version of the driver does).
3. The POLL_AND_CHECK_STATUS command handler is wrong: you use
16-bit status variable where 32-bit is necessary, and you
don't do any error-recovering that sf_intr() does. I blindly
fixed this, but I cannot test it on a real hardware.
I also "fixed" the #endif's. ;)
An updated patch can be found here:
http://people.freebsd.org/~ru/patches/if_sf.patch
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--i7F3eY7HS/tUJxUd
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBkc20qRfpzJluFF4RAmqFAJ0bFz8DMUsbNBdQUkZnebr6wepRewCfRCY/
A42N1F0oCEfZygGBKKskGz0=
=+7aa
-----END PGP SIGNATURE-----
--i7F3eY7HS/tUJxUd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041110081340.GD65475>