Date: Mon, 12 Feb 2018 01:08:11 -0500 From: Allan Jude <allanjude@freebsd.org> To: Warner Losh <imp@bsdimp.com>, "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329150 - head/etc/devd Message-ID: <3cd5ec93-caaa-8789-4caf-549296cd07dc@freebsd.org> In-Reply-To: <CANCZdfq48xtNH6f=ZQg%2Bn3Kyo_7J0Oh3gP2obyg4mHEFkP2V%2Bg@mail.gmail.com> References: <201802120454.w1C4sp4o086856@repo.freebsd.org> <201802120510.w1C5AUFY042400@pdx.rh.CN85.dnsmgr.net> <CANCZdfq48xtNH6f=ZQg%2Bn3Kyo_7J0Oh3gP2obyg4mHEFkP2V%2Bg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --zLBSGnQz9j6cL0IayiTIFlnDv8CAR2fUo Content-Type: multipart/mixed; boundary="EMF8l9UxPWgMFkXxBf9zctthxNCGElOib"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: Warner Losh <imp@bsdimp.com>, "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <3cd5ec93-caaa-8789-4caf-549296cd07dc@freebsd.org> Subject: Re: svn commit: r329150 - head/etc/devd References: <201802120454.w1C4sp4o086856@repo.freebsd.org> <201802120510.w1C5AUFY042400@pdx.rh.CN85.dnsmgr.net> <CANCZdfq48xtNH6f=ZQg+n3Kyo_7J0Oh3gP2obyg4mHEFkP2V+g@mail.gmail.com> In-Reply-To: <CANCZdfq48xtNH6f=ZQg+n3Kyo_7J0Oh3gP2obyg4mHEFkP2V+g@mail.gmail.com> --EMF8l9UxPWgMFkXxBf9zctthxNCGElOib Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-02-12 00:28, Warner Losh wrote: >=20 >=20 > On Sun, Feb 11, 2018 at 10:10 PM, Rodney W. Grimes > <freebsd@pdx.rh.cn85.dnsmgr.net <mailto:freebsd@pdx.rh.cn85.dnsmgr.net>= > > wrote: >=20 > [ Charset UTF-8 unsupported, converting... ] > > Author: imp > > Date: Mon Feb 12 04:54:51 2018 > > New Revision: 329150 > > URL: https://svnweb.freebsd.org/changeset/base/329150 > <https://svnweb.freebsd.org/changeset/base/329150>; > > > > Log: > >=C2=A0 =C2=A0Install devmatch.conf, don't install usb.conf >=20 > Doesnt this break devd and anyone depending on it? >=20 >=20 > I'm having problems understanding how it would break it? > =C2=A0 >=20 > Does usb.conf need to go in OBSOLETEFILES now? >=20 >=20 > Yes. It should... > =C2=A0 >=20 > Relnotes y? >=20 >=20 > Yes. It's hard to know where in the sequence of on-boarding a new > function where to put it. >=20 Previously Release Engineering has said they'd rather you mark a few too many things as Relnotes: Yes, than too few. In cases like this, it might make sense to flag the entire series of commits, so a year from now re@ stands a better chance of writing a coherent paragraph about what the change actually is, and how it impacts the user. > Warner > =C2=A0 >=20 >=20 > > Modified: > >=C2=A0 =C2=A0head/etc/devd/Makefile > > > > Modified: head/etc/devd/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > --- head/etc/devd/Makefile=C2=A0 =C2=A0 Mon Feb 12 04:52:25 2018=C2= =A0 =C2=A0 =C2=A0 =C2=A0 (r329149) > > +++ head/etc/devd/Makefile=C2=A0 =C2=A0 Mon Feb 12 04:54:51 2018=C2= =A0 =C2=A0 =C2=A0 =C2=A0 (r329150) > > @@ -12,13 +12,14 @@ FILES+=3D=C2=A0 =C2=A0apple.conf > >=C2=A0 .if ${MK_ACPI} !=3D "no" > >=C2=A0 FILES+=3D=C2=A0 =C2=A0 =C2=A0 asus.conf > >=C2=A0 .endif > > +FILES+=3Ddevmatch.conf > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^ missing tab >=20 > >=C2=A0 .if ${MK_HYPERV} !=3D "no" > >=C2=A0 FILES+=3D=C2=A0 =C2=A0 =C2=A0 hyperv.conf > >=C2=A0 .endif > >=C2=A0 .endif > > > >=C2=A0 .if ${MK_USB} !=3D "no" > > -FILES+=3D=C2=A0 =C2=A0 =C2=A0 uath.conf ulpt.conf usb.conf > > +FILES+=3D=C2=A0 =C2=A0 =C2=A0 uath.conf ulpt.conf > >=C2=A0 .endif > > > >=C2=A0 .if ${MK_ZFS} !=3D "no" >=20 > -- > Rod Grimes=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > =C2=A0rgrimes@freebsd.org <mailto:rgrimes@freebsd.org> >=20 >=20 --=20 Allan Jude --EMF8l9UxPWgMFkXxBf9zctthxNCGElOib-- --zLBSGnQz9j6cL0IayiTIFlnDv8CAR2fUo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJagS9LAAoJEBmVNT4SmAt+w4IQAMn+KKrU+Qkr5q4JI0ikZdWb bgDQpHibHRYQrT1LtsmRkjPe8fzM8YB6G+RlB3eZziEG+9feu7s3ppNnXAf7xLmU r9+N0/CenK8kw/GpIkkK7PKZco8GhK9GaBTKOf3Cl8puog2Lrcuc1QCWdSbQ7ubJ Yz6upo1DgwLw30sTnuGrsVjb5BdOYKUMrRp5CxG3AQVpZXpNPr5T3IiXcFhAlAKM wLydi1SB5gWEsHXkjXnfZelyymT0tb4N9XmBwYn/FJJnL6g1nUuriGbajwL/Xv+r HYKTtZugI0OYeLX7eNAjjz674DK6B3AgPyaib4woXn17RTF6cimek3CIob5TYVat 5Gml53wfR6cBJ6vZ7Gf5FRGaQ4rDWSJbyKSvtSe9eLsYXivD8cEoeDsaEANOmMjw hserRS0cZvZyslj2N1DfgW284Lw9PiPpzJE86TtlDfODPhBO6KUwRtxAAMQlNz4B 5DXCbmOSMlEiqDdhliCG0q6sn8XHOIVKesWKKPQkYmb01LfHUpp82rkeGpppnOYV kp1heNdC4vflZVU7UU8P7IERWPRAlbC+JhDXazDGRp8nsTXIB8/FCDU6/poNuLeR o14ZK4IOtz7yTU3Kx0JPq3bUzyBNURRpjwba7RKaVvNPxxQrSDVxlz++myND04vP n5oBjXOnxq4RDzT1SWGw =dZx+ -----END PGP SIGNATURE----- --zLBSGnQz9j6cL0IayiTIFlnDv8CAR2fUo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3cd5ec93-caaa-8789-4caf-549296cd07dc>