Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Nov 2025 04:30:51 +0000
From:      Jessica Clarke <jrtc27@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: aac0ef54dce9 - main - kern: Fix section name for embedded firmware blobs
Message-ID:  <692530fb.3b8ff.129f6fc4@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by jrtc27:

URL: https://cgit.FreeBSD.org/src/commit/?id=aac0ef54dce9d59a5ccc1151693906778cba45c9

commit aac0ef54dce9d59a5ccc1151693906778cba45c9
Author:     Jessica Clarke <jrtc27@FreeBSD.org>
AuthorDate: 2025-11-25 04:29:22 +0000
Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
CommitDate: 2025-11-25 04:29:22 +0000

    kern: Fix section name for embedded firmware blobs
    
    In practice this just ends up as an orphan section and so is placed next
    to .rodata-like sections, so it's pretty harmless, but not intended.
    
    Fixes:  a095390344fb ("Use a template assembly file for firmware object files.")
---
 sys/kern/firmw.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/kern/firmw.S b/sys/kern/firmw.S
index cd808d4a9396..1d74f17e449e 100644
--- a/sys/kern/firmw.S
+++ b/sys/kern/firmw.S
@@ -35,7 +35,7 @@
 #define	FIRMW_START(S)	__CONCAT(_binary_, __CONCAT(S, _start))
 #define	FIRMW_END(S)	__CONCAT(_binary_, __CONCAT(S, _end))
 
-	.section rodata, "a", %progbits
+	.section .rodata, "a", %progbits
 	.globl	FIRMW_START(FIRMW_SYMBOL)
 	.type	FIRMW_START(FIRMW_SYMBOL), %object
 FIRMW_START(FIRMW_SYMBOL):


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?692530fb.3b8ff.129f6fc4>