Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Nov 2010 16:40:49 +0200
From:      Mikolaj Golub <to.my.trociny@gmail.com>
To:        Lawrence Stewart <lstewart@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r215166 - in head: . sys/conf sys/netinet sys/netinet/cc sys/sys
Message-ID:  <86aalamyz2.fsf@zhuzha.ua1>
In-Reply-To: <4CE139C5.4010300@freebsd.org> (Lawrence Stewart's message of "Tue, 16 Nov 2010 00:46:45 %2B1100")
References:  <201011120641.oAC6fui3098584@svn.freebsd.org> <8662w17e90.fsf@kopusha.home.net> <4CDF3A58.6080505@freebsd.org> <86pqu8q6lb.fsf@kopusha.home.net> <4CE08BB6.1090304@freebsd.org> <86ipzyncqf.fsf@zhuzha.ua1> <4CE139C5.4010300@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Tue, 16 Nov 2010 00:46:45 +1100 Lawrence Stewart wrote:

 LS> Ok thanks. If you are or anyone else is feeling really adventurous, I
 LS> have created a series of patches that add better VIMAGE support to the
 LS> framework.

 LS> If you feel like testing them, they need to be applied in the following
 LS> order:

 LS> 1. Init the CC framework global state only once on system boot by
 LS> switching to a SYSINIT. (You already have this one)
 LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnetpanic_ccinit_v2.patch

 LS> 2. When unloading an algo module, loop through all TCP control blocks in
 LS> all vnets (instead of just the default vnet) to look for connections
 LS> using the algo.
 LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnet_algounloadcleanup.patch

 LS> 3. Move protocol specific implementation detail out of the core CC
 LS> framework (not vnet specific but useful cleanup).
 LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_tcpalgounload.patch

 LS> 4. Create a per-vnet variable to store a ptr to the vnet's default CC
 LS> algo and hook it up to a vnet aware sysctl handler. vnets can now choose
 LS> their own default from the global list of registered algos independently
 LS> of other vnets.
 LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_pervnet_defaultalgo.patch

 LS> It would be fine to test all of them in one go. The last one is the most
 LS> intrusive and the one I'd most like to see some testing done with. Only
 LS> if you feel like it of course.

Feeling virtually adventurous, applied them all on VirtualBox :-). This is the
box where the hang is not observed. It works ok for me so far. I will try at
home too (where the hang is observed) and let you know if there are any
issues.

-- 
Mikolaj Golub



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86aalamyz2.fsf>