Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Nov 2013 04:13:07 +0100
From:      Alberto Villa <avilla@FreeBSD.org>
To:        Matthias Andree <mandree@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r332275 - in head/Mk: . Scripts
Message-ID:  <CAJp7RHanHqH%2B=sCazgEKK3HuZk2CO03msvFE%2BST7wrACMr7LPg@mail.gmail.com>
In-Reply-To: <201310311907.r9VJ7cSi018085@svn.freebsd.org>
References:  <201310311907.r9VJ7cSi018085@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 31, 2013 at 8:07 PM, Matthias Andree <mandree@freebsd.org> wrote:
> Log:
>   bsd.stage.mk: Fewer false positives, much faster, easier maintenance.

check-stagedir.sh has some issues:

- It requires MTREE_FILE, thus not respecting NO_MTREE.

- It fails with ports relying on an additional "mtree port" (like
ports depending on gnomehier or kdehier4, e.g., multimedia/phonon). I
understand this is not an easy one, so I don't pretend to see it
fixed; or should we make them real mtree files (e.g.,
BSD.kde4.dist...)?

While here, bsd.stage.mk should be enclosed in post-makefile checks,
just like bsd.pkgng.mk, for completeness.
-- 
Alberto Villa, FreeBSD committer <avilla@FreeBSD.org>
http://people.FreeBSD.org/~avilla



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJp7RHanHqH%2B=sCazgEKK3HuZk2CO03msvFE%2BST7wrACMr7LPg>