Date: Mon, 30 Apr 2007 22:48:54 +0400 From: Andrey Chernov <ache@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c Message-ID: <20070430184854.GA87050@nagual.pp.ru> In-Reply-To: <20070430183624.GA73050@tirith.brixandersen.dk> References: <200704301656.l3UGuIqf048148@repoman.freebsd.org> <20070430183624.GA73050@tirith.brixandersen.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Apr 30, 2007 at 08:36:24PM +0200, Henrik Brix Andersen wrote:
> Todays changes to *env() appears to have broken stuff (my -CURRENT box
> fails to build many ports after these changes, due to missing
> environment variables in the build environment).
>=20
> Here is a simple test-case:
>=20
> $ env -vi foo=3Dbar env
> #env clearing environ
> #env setenv: foo=3Dbar
> #env executing: env
> #env arg[0]=3D 'env'
>=20
> Notice that the second instance of env(1) doesn't see the $foo
> environment variable.
>=20
> This is the output of the same test on my RELENG_6 box:
>=20
> $ env -vi foo=3Dbar env
> #env clearing environ
> #env setenv: foo=3Dbar
> #env executing: env
> #env arg[0]=3D 'env'
> foo=3Dbar
Thanx for the report, but please be patient a bit, work in the progress
and fix already planned soon.
To the matter: env incorrectly calls setenv("name=3D...", ...) which is
POSIX violation:
"The setenv( ) function shall fail if:
[EINVAL] The name argument is a null pointer, points to an empty string,=20
or points to a string containing an '=3D' character."
--=20
http://ache.pp.ru/
--C7zPtVaVf+AK4Oqc
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.3 (FreeBSD)
iD8DBQFGNjoWVg5YK5ZEdN0RAgCgAJ9Ea+GVihetvk9E1AI+2VSoq0IOZgCgs2+W
IEcVTmj9KW7Rh4FeUoGtKfI=
=NGvN
-----END PGP SIGNATURE-----
--C7zPtVaVf+AK4Oqc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070430184854.GA87050>