Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 05 Mar 2007 14:21:03 +0000
From:      "Bruce M. Simpson" <bms@FreeBSD.org>
To:        Eygene Ryabinkin <rea-fbsd@codelabs.ru>,  Andrew Thompson <thompsa@freebsd.org>
Cc:        freebsd-net@FreeBSD.org
Subject:   Re: kern/109815: wrong interface identifier at pfil_hooks for vlans +	if_bridge
Message-ID:  <45EC274F.7090201@FreeBSD.org>
In-Reply-To: <20070305125133.GR80319@codelabs.ru>
References:  <E1HNbWw-000LoF-Bo@pobox.codelabs.ru> <45E9F1E8.2000802@inse.ru> <20070304062203.GL80319@codelabs.ru> <E1HNbWw-000LoF-Bo@pobox.codelabs.ru> <45E9F1E8.2000802@inse.ru> <20070304160613.GN80319@codelabs.ru> <45EB4915.1090703@FreeBSD.org> <45EB4FD7.2000708@inse.ru> <45EB5869.1010100@FreeBSD.org> <20070305125133.GR80319@codelabs.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
Eygene Ryabinkin wrote:
> Will try to understand if it will cure my problem, thanks!
> Attaching my patch, just in case if freebsd gnats will be down ;))
>   

Thanks for this. It looks like Andrew may be in a better position to say 
if this fix should go in or not.

It is possible that if bridge changes the ifp and that the frame should 
be forwarded locally, i.e. to the upper protocol layers, that ifp should 
also be updated in ether_input() (as NetBSD does) to make sure that the 
later checks are against the updated ifp.

I have just changed this behaviour in p4 bms_netdev. Please try to test 
with this code. If you can't access p4, then I can extract an updated 
patch though this will take longer.

This should help to eliminate the need for DEV_CARP compile-time 
conditionals in if_bridge(4).

Regards,
BMS




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45EC274F.7090201>