Date: Fri, 1 Aug 2014 08:02:21 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Max Brazhnikov <makc@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, John Marino <marino@freebsd.org>, William Grzybowski <wg@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r363361 - in head/editors/fte: . files Message-ID: <CAALwa8=R2i9PA7R8VXHStZCDGy_ZFaYcBtRmY-_ZFq9k=toJ%2Bw@mail.gmail.com> In-Reply-To: <20140801051652.GA59625@FreeBSD.org> References: <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org> <20140730070412.GA97692@FreeBSD.org> <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc> <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 1, 2014 at 7:16 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Wed, Jul 30, 2014 at 06:13:48PM +0200, John Marino wrote:
>> On 7/30/2014 18:08, Alexey Dokuchaev wrote:
>> > Given some thought over it, I propose the following changes to makepatch:
>> >
>> > - default to dash (minus, '-')
>> > - provide a command line option (-s?) or make(1) variable (PATH_SEPARATOR)
>> > to override it when needed
>> > - assert that forced value is not something insane ('__', '::', '../../',
>> > etc.) -- basically, match it over a prerefined list of acceptable values
>> >
>> > I can cook up a patch unless John had beaten me on that already.
>>
>> Nope, go for it.
>
> Have a look (attached). I've also fixed annoying bug (appending of leading
> "./" in the ---/+++ lines of generated patches), and improved the comment.
Hi,
Refusing _ in seperator seems total bullshit, this convention has
been in place for 9 years, wtf!?
Cheers,
Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=R2i9PA7R8VXHStZCDGy_ZFaYcBtRmY-_ZFq9k=toJ%2Bw>