Date: Mon, 20 Jul 2009 16:19:42 +0000 (UTC) From: Sean Nicholas Barkas <snb@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/ufs/ufs ufs_dirhash.c Message-ID: <200907201619.n6KGJtP8060599@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
snb 2009-07-20 16:19:42 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_7)
sys/ufs/ufs ufs_dirhash.c
Log:
SVN rev 195783 on 2009-07-20 16:19:42Z by snb
MFC r195003:
Fix a bug reported by pho@ where one can induce a panic by decreasing
vfs.ufs.dirhash_maxmem below the current amount of memory used by dirhash. When
ufsdirhash_build() is called with the memory in use greater than dirhash_maxmem,
it attempts to free up memory by calling ufsdirhash_recycle(). If successful in
freeing enough memory, ufsdirhash_recycle() leaves the dirhash list locked. But
at this point in ufsdirhash_build(), the list is not explicitly unlocked after
the call(s) to ufsdirhash_recycle(). When we next attempt to lock the dirhash
list, we will get a "panic: _mtx_lock_sleep: recursed on non-recursive mutex
dirhash list".
Approved by: dwmalone (mentor)
Revision Changes Path
1.23.2.3 +4 -1 src/sys/ufs/ufs/ufs_dirhash.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907201619.n6KGJtP8060599>