Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 07 Oct 2022 13:43:33 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 266236] ZFS NFS : .zfs/snapshot : Stale file handle
Message-ID:  <bug-266236-3630-ABgLZp4Sh5@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-266236-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-266236-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266236

Mark Johnston <markj@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237124|0                           |1
        is obsolete|                            |

--- Comment #18 from Mark Johnston <markj@FreeBSD.org> ---
Created attachment 237140
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D237140&action=
=3Dedit
proposed patch

It looks like the fid_gen > 1 check is related to the implementation of
zfsctl_snapdir_fid(), which is Linux-specific and sets the generation numbe=
r to
`!!d_mountpoint(dentry)`.  There is a comment explaining this: "we encode
whether snapdir is already mounted in gen field".

As far as I can see we do not do anything similar when constructing FIDs on
FreeBSD, so the check is wrong there and we should simply drop it.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-266236-3630-ABgLZp4Sh5>