Date: Mon, 29 Oct 2012 09:21:00 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: YongHyeon PYUN <pyunyh@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Andre Oppermann <andre@FreeBSD.org> Subject: Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf Message-ID: <20121029052100.GO70741@FreeBSD.org> In-Reply-To: <20121029204104.GA1431@michelle.cdnetworks.com> References: <201210262106.q9QL6YgY000943@svn.freebsd.org> <508BBE6C.7010409@freebsd.org> <20121027220137.GJ70741@FreeBSD.org> <20121029204104.GA1431@michelle.cdnetworks.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 29, 2012 at 01:41:04PM -0700, YongHyeon PYUN wrote: Y> On Sun, Oct 28, 2012 at 02:01:37AM +0400, Gleb Smirnoff wrote: Y> > On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote: Y> > A> On 26.10.2012 23:06, Gleb Smirnoff wrote: Y> > A> > Author: glebius Y> > A> > Date: Fri Oct 26 21:06:33 2012 Y> > A> > New Revision: 242161 Y> > A> > URL: http://svn.freebsd.org/changeset/base/242161 Y> > A> > Y> > A> > Log: Y> > A> > o Remove last argument to ip_fragment(), and obtain all needed information Y> > A> > on checksums directly from mbuf flags. This simplifies code. Y> > A> > o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in Y> Y> I'm not sure whether ti(4)'s checksum offloading for IP fragmented Y> packets(CSUM_IP_FRAGS) still works after this change. ti(4) Y> requires CSUM_IP should be set for IP fragmented packets. Not sure Y> whether it's a bug or not. I have a ti(4) controller but I don't Y> remember where I can find it and don't have a link Y> parter(1000baseSX) to test it. :-( ti(4) declares both CSUM_IP and CSUM_IP_FRAGS, so ip_fragment() won't do software checksums, and thus won't clear these flags. Potentially a driver that announces one flag in if_hwassist but relies on couple of flags to be set on mbuf is not correct. If a driver can't do single checksum processing independently from others, then it should set or clear appropriate flags in if_hwassist as a group. Y> > A> > hardware. Some driver may not announce CSUM_IP in theur if_hwassist, ^^^^^^^^ Oh, that was a typo! Software was meant. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121029052100.GO70741>