Date: Fri, 13 Apr 2007 06:50:07 GMT From: Rink Springer <rink@FreeBSD.org> To: freebsd-ppc@FreeBSD.org Subject: Re: powerpc/111522: Add support for the ofw bus interface to nexus Message-ID: <200704130650.l3D6o7Bs053279@freefall.freebsd.org>
index | next in thread | raw e-mail
The following reply was made to PR powerpc/111522; it has been noted by GNATS. From: Rink Springer <rink@FreeBSD.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: powerpc/111522: Add support for the ofw bus interface to nexus Date: Fri, 13 Apr 2007 08:39:56 +0200 Hi Andrew, On Fri, Apr 13, 2007 at 11:00:33AM +1200, Andrew Turner wrote: > + if ((dinfo = device_get_ivars(dev)) == 0) style(9) says you should use NULL instead of 0. Other than this, I can't see anything wrong with the patch. Cheers, -- Rink P.W. Springer - http://rink.nu "It is such a quiet thing, to fall. But yet a far more terrible thing, to admit it." - Darth Trayahome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704130650.l3D6o7Bs053279>