Date: Tue, 03 Dec 2013 02:14:39 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: gjb@FreeBSD.org Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r258848 - user/hrs/releng/release Message-ID: <20131203.021439.505942678651568262.hrs@allbsd.org> In-Reply-To: <20131202160333.GI1839@glenbarber.us> References: <20131202152054.GH1839@glenbarber.us> <20131203.005247.163975247035953783.hrs@allbsd.org> <20131202160333.GI1839@glenbarber.us>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Glen Barber <gjb@FreeBSD.org> wrote
in <20131202160333.GI1839@glenbarber.us>:
gj> > - In the current release.sh, variables unintentionally set in the
gj> > builder's environment still pollutes commands which run in
gj> > release.sh when the variables are not set in the script but
gj> > accepted by make or other utilities. Catching all of the variables
gj> > is quite difficult.
gj> >
gj>
gj> Do you have an example? If you are referring to a previous problem with
gj> 10.x builds, the actual problem was a race in the build toolchain, and
gj> not variable pollution. I was able to confirm this was the case there.
One of the surprising examples I experienced was that svn co
sometimes fails with LC_ALL=C. Subversion stores repo data in UTF-8,
so iconv conversion happens when LC_ALL is not UTF-8 compatible (and
it broke "svn co head/" a while ago). Besides, TARGET, TARGET_ARCH,
MAKEOBJDIR, MAKEOBJDIRPREFIX, and OBJDIR are also dangerous and
unprotected variables for make(1). An empty TARGET caused an
infinite loop in libc build, so I fixed it in Makefile yesterday.
All of them are examples of "unintentional" variables, so being
careful is enough to avoid them, though.
gj> > Anyway, I do not have a strong opinion if using FOO=A or : ${FOO:=A}.
gj> > I agree that the latter assumes all of the envvars must be under
gj> > control and it needs one more step than just invoking the script, and
gj> > a leaked variable can break the build. If you do not like it, I will
gj> > change them with FOO=A.
gj> >
gj>
gj> Yes, please.
Will do. I will not merge the changes before 10.0R is out in any
case.
-- Hiroki
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)
iEYEABECAAYFAlKcv/8ACgkQTyzT2CeTzy0KPgCfaXp+xOndbt78S0S8uT8oL62x
5/IAoNkkakGKkK3QkqFmm18vBaICwdXM
=DizG
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131203.021439.505942678651568262.hrs>