Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Nov 2021 14:24:04 GMT
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: aeacf172fd29 - main - twsi: remove redundant write of control register
Message-ID:  <202111261424.1AQEO4b8002518@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by avg:

URL: https://cgit.FreeBSD.org/src/commit/?id=aeacf172fd29b16b3661ff057c9abb238baba813

commit aeacf172fd29b16b3661ff057c9abb238baba813
Author:     Andriy Gapon <avg@FreeBSD.org>
AuthorDate: 2021-11-26 08:09:59 +0000
Commit:     Andriy Gapon <avg@FreeBSD.org>
CommitDate: 2021-11-26 14:18:30 +0000

    twsi: remove redundant write of control register
    
    The write at the end of twsi_intr() already handles all cases, no need
    to have another write for TWSI_STATUS_START / TWSI_STATUS_RPTD_START.
    
    MFC after:      3 weeks
---
 sys/dev/iicbus/twsi/twsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/dev/iicbus/twsi/twsi.c b/sys/dev/iicbus/twsi/twsi.c
index 4a20d7ea35b6..b94396883be5 100644
--- a/sys/dev/iicbus/twsi/twsi.c
+++ b/sys/dev/iicbus/twsi/twsi.c
@@ -591,7 +591,6 @@ twsi_intr(void *arg)
 		else
 			TWSI_WRITE(sc, sc->reg_data,
 			    sc->msgs[sc->msg_idx].slave & ~LSB);
-		TWSI_WRITE(sc, sc->reg_control, sc->control_val);
 		break;
 
 	case TWSI_STATUS_ADDR_W_ACK:


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202111261424.1AQEO4b8002518>