Date: Fri, 16 Mar 2018 09:33:12 +0000 From: Steven Crangle <Steven@stream-technologies.com> To: Kristof Provost <kristof@sigsegv.be> Cc: "freebsd-pf@freebsd.org" <freebsd-pf@freebsd.org>, "eri@freebsd.org" <eri@freebsd.org> Subject: Re: Required modification for round robin napt with ip address prefixes Message-ID: <AM4PR07MB3186BEE73779C5CF2496CE0D9BD70@AM4PR07MB3186.eurprd07.prod.outlook.com> In-Reply-To: <8AE55F12-E53E-40BE-A99A-CB8D9B306806@sigsegv.be> References: <AM4PR07MB3186446455FD90C99E9B62C89BD10@AM4PR07MB3186.eurprd07.prod.outlook.com>, <8AE55F12-E53E-40BE-A99A-CB8D9B306806@sigsegv.be>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Thanks to both of you for your responses. I'm currently working on a reduce= d test case that will hopefully reproduce the issue. I'll also reach out to glebius@ too, as it would be great to get a bit more= insight into how to approach a fix for the issue. Hopefully they can point me in the right direction and I can work on a fix! Regards Steven ________________________________ From: Kristof Provost <kristof@sigsegv.be> Sent: 15 March 2018 19:50:45 To: Steven Crangle Cc: freebsd-pf@freebsd.org Subject: Re: Required modification for round robin napt with ip address pre= fixes On 14 Mar 2018, at 18:30, Steven Crangle wrote: > I was looking for some advice on the type of locking required to stop > a box panicking that utilises both napt and ip address prefixes. > > My colleague made a post a while ago, and we ended up getting > distracted fixing other panics that showed up. But we've now returned > to try and figure out the issue. > > > The relevant code is in pf_lb.c : 424 > I=92d recommend talking to glebius@. He did the locking code and wrote the comment block discussing the locking choices around PF_POOL_ROUNDROBIN. I suspect it=92s a bit more complicated that a straightforward PF_RULES_WLOCK() would fix. The locking model for pf is pretty complex. I=92ve not had the time to really dig into this, so I can=92t give more advice right now. Regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AM4PR07MB3186BEE73779C5CF2496CE0D9BD70>