Date: Wed, 29 May 2002 16:53:39 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: "J. Mallett" <jmallett@FreeBSD.ORG> Cc: "David O'Brien" <obrien@FreeBSD.ORG>, Julian Elischer <julian@elischer.org>, John Baldwin <jhb@FreeBSD.ORG>, FreeBSD current users <current@FreeBSD.ORG> Subject: Re: Seeking OK to commit KSE MIII Message-ID: <200205292353.g4TNrdH7063967@apollo.backplane.com> References: <XFMail.20020529124710.jhb@FreeBSD.org> <Pine.BSF.4.21.0205291057020.12315-100000@InterJet.elischer.org> <20020529124434.A2156@dragon.nuxi.com> <200205292007.g4TK71YD062671@apollo.backplane.com> <20020529152159.A82752@FreeBSD.ORG>
next in thread | previous in thread | raw e-mail | index | archive | help
: :When you make the code more readable, you introduce further diffs, and you :leave no reference against the original code of where the functional changes :are. Either make the "base" code cleaned up by committing non-functional :changes first, or commit against the "base" code your functional changes, :and then clean it up. Otherwise, it's a pain in the ass to sort things out. : :And for what it's worth, I'm all for readability improvements in our code, I :just also like to go and view diffs sometimes and try to figure out what's :changed. : :But I think you're also right on the rule of thumb thing, if someone does not :want to do this favor to everyone who might want to read diffs or annotate :changes to the code and get something meaningful, that's fine. I've done it Oh come on, that is not what I meant at all and you know it. What is this junk about 'not wanting to do this favor to everyone'? I never said that. I didn't even come CLOSE to saying that or infering that. It is complete and utter bullshit and a severe... nay, *EXTREME* twisting of what I said. You missed the point entirely. Go back and READ WHAT I WROTE. I made it pretty damn clear. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205292353.g4TNrdH7063967>