Date: Fri, 18 Jan 2008 12:19:51 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet tcp_usrreq.c Message-ID: <200801181219.m0ICJp8L026279@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2008-01-18 12:19:51 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_usrreq.c
Log:
In tcp_ctloutput(), don't hold the inpcb lock over sooptcopyin(), rather,
drop the lock and then re-acquire it, revalidating TCP connection state
assumptions when we do so. This avoids a potential lock order reversal
(and potential deadlock, although none have been reported) due to the
inpcb lock being held over a page fault.
MFC after: 1 week
PR: 102752
Reviewed by: bz
Reported by: Václav Haisman <v dot haisman at sh dot cvut dot cz>
Revision Changes Path
1.166 +55 -25 src/sys/netinet/tcp_usrreq.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801181219.m0ICJp8L026279>