Date: Tue, 14 Apr 2020 22:37:36 +0000 From: Brooks Davis <brooks@freebsd.org> To: Conrad Meyer <cem@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359937 - in head/sys: amd64/linux amd64/linux32 arm64/linux compat/freebsd32 compat/linux dev/ipmi dev/mpr dev/mps dev/mpt i386/linux kern sys Message-ID: <20200414223736.GA78726@spindle.one-eyed-alien.net> In-Reply-To: <CAG6CVpWWMtC7d2ZHjWZ73rZgEzkrD%2BLBM0Hkv%2Bg3WEpmMkeL0g@mail.gmail.com> References: <202004142030.03EKUmOJ080400@repo.freebsd.org> <CAG6CVpWWMtC7d2ZHjWZ73rZgEzkrD%2BLBM0Hkv%2Bg3WEpmMkeL0g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 14, 2020 at 03:08:24PM -0700, Conrad Meyer wrote: > Brooks, >=20 > On Tue, Apr 14, 2020 at 13:31 Brooks Davis <brooks@freebsd.org> wrote: >=20 > > Author: brooks > > Date: Tue Apr 14 20:30:48 2020 > > New Revision: 359937 > > URL: https://svnweb.freebsd.org/changeset/base/359937 > > > > Log: > > Centralize compatability translation macros. > > > > Copy the CP, PTRIN, etc macros from freebsd32.h into a sys/abi_compat= =2Eh > > and replace existing definitation with includes where required. This > > eliminates duplicate code and allows Linux and FreeBSD compatability > > headers to be included in the same files. > > > > Input from: cem, jhb >=20 >=20 > You dismissed my input, so I don???t think there???s a good reason to sug= gest I > was involved with the revision. I apologize. I did make some (admittedly trivial) changes in response to your feedback and thought it was worth a mention. Your other proposed suggestions do seem worth exploring, but they were an enormous expansion of scope from a tiny bit of code consolidation to touching a large portion of macro sites. -- Brooks --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeljsvAAoJEKzQXbSebgfAY0wIAI97gpft0KBgvTP2z58mBLbU n1jdfZh7Pf5ahr50MErTS4SlVBQJnEv8VbBmz1YPoj+4LvTRGNrc3GJ+h++zPR1M GJ8FC9kDJk6ltq6hzw0GqVPDXrwuOoJaILmlfHv56dyEKWXoC9/mbMW7pKDlr1gD ZSiJyCfpD3jhA4GD34Pl6UmHx+2ccKhYmprbrR5jtY8Xo6CrAcPzcGIpx4F3BrxD NMqd1Gqf4i7FNkMsaUIfoRYAt1receh4LZ+XQAHcn2W9nPf9InoIg/KSxQUy2cf9 gnl6HT9rIglBb27af34ETmMiG5BeYNSRFINBgjQjNYPLKRy+/itJNUWDx+0cClY= =MZ+3 -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200414223736.GA78726>