Date: Thu, 12 May 2016 19:50:15 +0000 (UTC) From: Garrett Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r299561 - user/ngie/ntb-hacking/sys/dev/ntb/if_ntb Message-ID: <201605121950.u4CJoFff032176@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Thu May 12 19:50:14 2016 New Revision: 299561 URL: https://svnweb.freebsd.org/changeset/base/299561 Log: Remove bogus if_free (before ether_ifattach) when ntb_transport_probe fails if_free does a lot more than just free memory; it stops packet processing. This might fix panic on detach after r290684 when the transport is already in use, i.e. when the net_softc context is fully populated and "valid" due to use in another subsystem that's directly poking at ntb_hw0 Modified: user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c Modified: user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c ============================================================================== --- user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c Thu May 12 19:47:37 2016 (r299560) +++ user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c Thu May 12 19:50:14 2016 (r299561) @@ -419,7 +419,6 @@ ntb_setup_interface(void) rc = ntb_transport_probe(net_softc.ntb); if (rc != 0) { printf("ntb: Cannot init transport: %d\n", rc); - if_free(net_softc.ifp); return (rc); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605121950.u4CJoFff032176>