Date: Sat, 7 Jan 2012 23:41:17 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-rc@FreeBSD.org Subject: Re: Making use of set_rcvar. Message-ID: <20120107224116.GB1674@garage.freebsd.pl> In-Reply-To: <4F08C95F.6040808@FreeBSD.org> References: <20120106141301.GE1693@garage.freebsd.pl> <4F079A76.3030306@FreeBSD.org> <20120107112538.GC1696@garage.freebsd.pl> <4F08C95F.6040808@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--JP+T4n/bALQSJXh8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 07, 2012 at 02:38:23PM -0800, Doug Barton wrote: > On 01/07/2012 03:25, Pawel Jakub Dawidek wrote: > > On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote: > >> On 01/06/2012 06:13, Pawel Jakub Dawidek wrote: > >>> Any objections? > >>> > >>> http://people.freebsd.org/~pjd/patches/set_rcvar.patch > >>> > >>> This patch only changes scripts where set_rcvar can be used with no > >>> arguments. > >> > >> Please don't do this. > >> > >> Jilles already pointed out the important reason, it adds pointless > >> forks. I suggested a long time ago that we remove set_rcvar altogether > >> but I got a lot of resistance to it, and never pursued it. Perhaps it's > >> time to revisit that. > >=20 > > It is a total mess now then and it is definiately not intuitive when > > there are much more bad examples than good ones: >=20 > I agree, which is why I previously proposed assigning them all directly > when possible (which is in almost all cases). If no one speaks up > opposing this idea in the next few days I'm still prepared to proceed. Don't forget to update documentation (rc(8)). --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --JP+T4n/bALQSJXh8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8IygwACgkQForvXbEpPzSbWACfasMixEirDarFsJWARZvgNGNf VosAn2BP+IZDHHl0/7Mu7A69mlWTm8oD =/w1p -----END PGP SIGNATURE----- --JP+T4n/bALQSJXh8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120107224116.GB1674>