Date: Mon, 2 Mar 2015 00:02:07 +0000 From: "rstone (Ryan Stone)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Commented On] D1986: Teach lagg(4) to change MTU Message-ID: <ac88c5358f8d1af7cba79d144f29fa51@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org> References: <differential-rev-PHID-DREV-i34kfg4qpajia7fo5u5l-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
rstone added inline comments. INLINE COMMENTS sys/net/if_lagg.c:1772 style(9) says to not include unnecessary braces (which I personally disagree with, but what can you do?) sys/net/if_lagg.c:1773 style(9): put brackets around the return value: return (0); sys/net/if_lagg.c:1811 I find the flow control here a bit confusing (my first read through, I thought that err2 could be used unitinialized). Given that you have a continue in the if block, I would find it clearer to not have an else here REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: ae, freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ac88c5358f8d1af7cba79d144f29fa51>