Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Feb 2021 08:19:51 +0000
From:      bugzilla-noreply@freebsd.org
To:        fs@FreeBSD.org
Subject:   [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash
Message-ID:  <bug-253158-3630-ryq9XV33ap@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-253158-3630@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253158

--- Comment #42 from Harald Schmalzbauer <bugzilla.freebsd@omnilan.de> ---
(In reply to Konstantin Belousov from comment #41)

I tried both diffs on their own on main-14 post
8563de2f2799b2cb6f2f06e3c9dddd48dca2a986 and you are right that both fix the
panic with my simple test (ffs_snapshot.c=>fstyp-success; patch
-R=>fstyp-panic; vfs_vnops.c=>fstyp-"filesystem not recognized" but no panic).

As you might have noticed, the code path is far beyond my skills.
But I think I understand your explanation.
What I do not understand is why it wasn't a problem for Kirk McKusick e.g.
Depends on cache size?

Here's the full output of the vfs_vnops.c-only-patched kernel and fstyp(8)
result:
fstyp: fread: Operation not permitted
fstyp: /.snap/.test2: filesystem not recognized

Thanks,
-harry

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253158-3630-ryq9XV33ap>