Date: Tue, 16 Aug 2022 14:41:51 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Message-ID: <4ed11043-d368-3084-bb21-2b794e9da748@FreeBSD.org> In-Reply-To: <YvuD7%2BoK6RZ/DLzH@FreeBSD.org> References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <Yvq1lQqmq3Mwv9ZJ@kib.kiev.ua> <F33312A7-B4B3-4D1A-9FE6-7CEF4E0F4BD9@freebsd.org> <A9D9B817-8E18-49A5-87A0-BDD9FA748549@FreeBSD.org> <YvuD7%2BoK6RZ/DLzH@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2022-08-16 13:47, Alexey Dokuchaev wrote: > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: >> ... >> But I think it is better to have the definitions matching the >> declarations exactly. We should sweep through the whole tree and get >> rid of all K&R functions too. I believe Warner wanted to attempt that. > > I won't comment on the technical side of things, but seeing this plethora > of identical commits is not just annoying, but pessimizes blaming as well. I don't see any reason why this would "pessimize blaming"? What do you mean with that? > Why can't it all be done in more coarse pieces, if not one commit? Because then somebody else will probably complain "why everything in one commit, it should be fine-grained"? It has to be fixed or worked around either way. I'm now more inclined to put in a suppression for this warning, since apparently they are just seen as "annoying". It is probably easier to just kick the can down the road again... Btw, similar issues affect ports, where we can either globally suppress new warnings (temporarily or permanently) and hope that the future won't catch up, or gradually start fixing things. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265425#c13 for more details. -Dimitry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ed11043-d368-3084-bb21-2b794e9da748>