Date: Tue, 16 Aug 2022 06:54:57 -0600 From: Warner Losh <imp@bsdimp.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Dimitry Andric <dim@freebsd.org>, Jessica Clarke <jrtc27@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Message-ID: <CANCZdfqY2_8PJY4=k_BiOkuqbtsk_TVZh7Z3-XA=H0hsAP3KQA@mail.gmail.com> In-Reply-To: <YvuD7%2BoK6RZ/DLzH@FreeBSD.org> References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <Yvq1lQqmq3Mwv9ZJ@kib.kiev.ua> <F33312A7-B4B3-4D1A-9FE6-7CEF4E0F4BD9@freebsd.org> <A9D9B817-8E18-49A5-87A0-BDD9FA748549@FreeBSD.org> <YvuD7%2BoK6RZ/DLzH@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Aug 16, 2022 at 5:48 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > ... > > But I think it is better to have the definitions matching the > > declarations exactly. We should sweep through the whole tree and get > > rid of all K&R functions too. I believe Warner wanted to attempt that. > > I won't comment on the technical side of things, but seeing this plethora > of identical commits is not just annoying, but pessimizes blaming as well. > Why can't it all be done in more coarse pieces, if not one commit? > I actually like it and don't see how it pessimizes blame. We have to do the changes, and it's better that we be able to back out or merge them one at a time. It's a huge pain to have to cherry pick a huge commit because of divergence in the target branch. Please do not take this suggestion to heart. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 16, 2022 at 5:48 AM Alexey Dokuchaev <<a href="mailto:danfe@freebsd.org">danfe@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote:<br> > ...<br> > But I think it is better to have the definitions matching the<br> > declarations exactly. We should sweep through the whole tree and get<br> > rid of all K&R functions too. I believe Warner wanted to attempt that.<br> <br> I won't comment on the technical side of things, but seeing this plethora<br> of identical commits is not just annoying, but pessimizes blaming as well.<br> Why can't it all be done in more coarse pieces, if not one commit?<br></blockquote><div><br></div><div>I actually like it and don't see how it pessimizes blame. We have to do</div><div>the changes, and it's better that we be able to back out or merge them</div><div>one at a time. It's a huge pain to have to cherry pick a huge commit because</div><div>of divergence in the target branch. Please do not take this suggestion to heart.</div><div><br></div><div>Warner</div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqY2_8PJY4=k_BiOkuqbtsk_TVZh7Z3-XA=H0hsAP3KQA>