Date: Tue, 16 Aug 2022 07:00:00 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Dimitry Andric <dim@freebsd.org>, Jessica Clarke <jrtc27@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Message-ID: <20220816140000.365C5150@slippy.cwsent.com> In-Reply-To: <YvuD7%2BoK6RZ/DLzH@FreeBSD.org> References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> <Yvq1lQqmq3Mwv9ZJ@kib.kiev.ua> <F33312A7-B4B3-4D1A-9FE6-7CEF4E0F4BD9@freebsd.org> <A9D9B817-8E18-49A5-87A0-BDD9FA748549@FreeBSD.org> <YvuD7%2BoK6RZ/DLzH@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <YvuD7+oK6RZ/DLzH@FreeBSD.org>, Alexey Dokuchaev writes: > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > ... > > But I think it is better to have the definitions matching the > > declarations exactly. We should sweep through the whole tree and get > > rid of all K&R functions too. I believe Warner wanted to attempt that. > > I won't comment on the technical side of things, but seeing this plethora > of identical commits is not just annoying, but pessimizes blaming as well. > Why can't it all be done in more coarse pieces, if not one commit? Agreed. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e**(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220816140000.365C5150>