Date: Tue, 4 Dec 2018 09:11:07 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Yuri Pankov <yuripv@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341446 - head/release/amd64 Message-ID: <201812041711.wB4HB7Fc037202@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Alexey Dokuchaev wrote: > > On Mon, Dec 03, 2018 at 10:31:57PM +0000, Yuri Pankov wrote: > >> New Revision: 341446 > >> URL: https://svnweb.freebsd.org/changeset/base/341446 > >> > >> Log: > >> mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs. > >> > >> This fixes 'cdrom' target in the case when world was built by user, > >> and not root. > > > > Could you please explain why -p should not have been used here? I fail > > to understand this from the commit log. I've always considered preserving > > various file metadata as a good thing to do, and this commit puzzles me. > > Because the target is on msdosfs, and the only metadata that can be > preserved is modification time which isn't that useful with the file > being hidden in ESP. OTOH, 'cp -p' fails trying to preserve owner/group > if source is not owned by root (as commit message says). Additional > 'chmod' call done in HBSD doesn't do much as well -- it seems we can > only set/unset owner's 'write' flag which corresponds to DOS 'readonly' > attribute. > I agree with this assesment, and the present state of the script, besides cp followed by chmod is usually spelled ${INSTALL}. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812041711.wB4HB7Fc037202>